-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to the latest Bootstrap version #19225
Comments
I think Bootstrap was past! |
Thanks for your feedback @KKacer. |
Related #23017 |
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process. |
Thanks for contacting us. |
Met today and we agreed on a plan of record for identity ui for 6.0:
cc @danroth27 @blowdart @DamianEdwards @javiercn @pranavkm @mkArtakMSFT @adityamandaleeka |
Bootstrap 5.0.2 has been merged in #34052 Still need follow up PR to add back the ability to switch back to V4 |
@deepchoudhery we have updated to bootstrap5 for net6.0 by default, can you help identify what changes need to go into https://github.com/dotnet/Scaffolding/tree/main/src/Scaffolding/VS.Web.CG.Mvc/Templates/Identity/Bootstrap4/wwwroot for the scaffolding side of things? |
Yes, I'll add an item to track for 6.0-rc1. I'll follow up soon. |
@HaoK just used the updated templates for the first time and noticed a few spacing/margin issues. Are these known and being fixed? e.g. |
Yeah @blowdart just went over them for me, we think its just a matter of removing the form-group, I will have a PR open for this today soon, I'll add you to the review |
Looks like @deepchoudhery merged the scaffolding side of things today 🎉 |
There were several breaking changes in Bootstrap 4 (from Bootstrap 3) which we also need to react to as part of this upgrade.
This issue will also be used to track all related work to the bootstrap 5 update:
The text was updated successfully, but these errors were encountered: