Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest Bootstrap version #19225

Closed
2 tasks done
mkArtakMSFT opened this issue Feb 21, 2020 · 13 comments
Closed
2 tasks done

Upgrade to the latest Bootstrap version #19225

mkArtakMSFT opened this issue Feb 21, 2020 · 13 comments
Assignees
Labels
affected-medium This issue impacts approximately half of our customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-templates severity-major This label is used by an internal tool
Milestone

Comments

@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented Feb 21, 2020

There were several breaking changes in Bootstrap 4 (from Bootstrap 3) which we also need to react to as part of this upgrade.

This issue will also be used to track all related work to the bootstrap 5 update:

  • identity ui/scaffolding
  • project template fixes
@mkArtakMSFT mkArtakMSFT added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Feb 21, 2020
@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Feb 21, 2020
@KKacer
Copy link

KKacer commented Feb 25, 2020

I think Bootstrap was past!
By the all recent changes and news in CSS, there is no need for bootstrap.
tying more and more the platform and components to a 3rd party library will add more time and hassle for people who try to make more pure or more customized things.
I believe BootStrap was past though Blazor can be the future.
So if possible while you try to consider the needs of web newbies, consider 1 extra scenario without Bootstrap, Materialize, and font-awesome, Jquery things, which none of them are standards, they may make a buzz for a period and then be gone, and each person can have it's own choice or custom scenario.
So personally I suggest not invest on bootsrap much, just may be there as an option, instead invest more on the standards. Like considering CSS Grid, FlexBox, ...

@mkArtakMSFT
Copy link
Member Author

Thanks for your feedback @KKacer.
We'll definitely think about these points you've mentioned when we will get to handling this issue.

@mkArtakMSFT
Copy link
Member Author

Related #23017

@ghost
Copy link

ghost commented Jul 21, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@mkArtakMSFT mkArtakMSFT changed the title Upgrade to the latest Bootstrap version (4.4 at the moment) Upgrade to the latest Bootstrap version Nov 19, 2020
@ghost
Copy link

ghost commented Jan 11, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@javiercn javiercn added affected-medium This issue impacts approximately half of our customers severity-major This label is used by an internal tool labels Feb 19, 2021 — with ASP.NET Core Issue Ranking
@HaoK HaoK self-assigned this May 19, 2021
@ghost ghost added the Working label May 24, 2021
@HaoK HaoK linked a pull request May 24, 2021 that will close this issue
@HaoK HaoK removed the Working label May 27, 2021
@ghost ghost added the Working label Jun 14, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0-preview7, 6.0-rc1 Jul 8, 2021
@HaoK
Copy link
Member

HaoK commented Jul 12, 2021

Met today and we agreed on a plan of record for identity ui for 6.0:

  • Both V4/V5 pages and assets will again live in the identity UI package, just like before with V3/V4
  • We will need to come up with a new page model convention to make this work (will sync with @pranavkm )
  • For 7.0 we can revisit and see if we can switch to UI.Bootstrap5/BootstrapX dlls but too risky to change this late for 6.0

cc @danroth27 @blowdart @DamianEdwards @javiercn @pranavkm @mkArtakMSFT @adityamandaleeka

@HaoK
Copy link
Member

HaoK commented Aug 4, 2021

Bootstrap 5.0.2 has been merged in #34052

Still need follow up PR to add back the ability to switch back to V4

@HaoK
Copy link
Member

HaoK commented Aug 7, 2021

@deepchoudhery we have updated to bootstrap5 for net6.0 by default, can you help identify what changes need to go into https://github.com/dotnet/Scaffolding/tree/main/src/Scaffolding/VS.Web.CG.Mvc/Templates/Identity/Bootstrap4/wwwroot for the scaffolding side of things?

@deepchoudhery
Copy link
Member

Yes, I'll add an item to track for 6.0-rc1. I'll follow up soon.

@DamianEdwards
Copy link
Member

@HaoK just used the updated templates for the first time and noticed a few spacing/margin issues. Are these known and being fixed? e.g.
image

@HaoK
Copy link
Member

HaoK commented Aug 9, 2021

Yeah @blowdart just went over them for me, we think its just a matter of removing the form-group, I will have a PR open for this today soon, I'll add you to the review

@HaoK
Copy link
Member

HaoK commented Aug 9, 2021

#35197

@HaoK HaoK modified the milestones: 6.0-rc1, 6.0-rc2 Aug 18, 2021
@HaoK
Copy link
Member

HaoK commented Sep 9, 2021

Looks like @deepchoudhery merged the scaffolding side of things today 🎉

@HaoK HaoK closed this as completed Sep 9, 2021
@ghost ghost added Done This issue has been fixed and removed Working labels Sep 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-medium This issue impacts approximately half of our customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-templates severity-major This label is used by an internal tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants