Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo breaking change for OptionsWrapper<T>.Remove(string) and Add(string, TOptions) #2983

Closed
Eilon opened this issue Mar 21, 2018 · 1 comment
Closed

Undo breaking change for OptionsWrapper<T>.Remove(string) and Add(string, TOptions) #2983

Eilon opened this issue Mar 21, 2018 · 1 comment
Assignees
@HaoK
Labels
bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
2.1.0-preview2

Comments

@Eilon
Copy link
Member

Eilon commented Mar 21, 2018 •
edited
Loading

A breaking change was introduced in 2.1 for the methods on OptionsWrapper<T>: Remove(string) and Add(string, TOptions).

This breaking change doesn't seem worthwhile, given how trivial it is to just leave the unused APIs there.

Guidelines on how to obsolete members is here: https://github.com/aspnet/Home/wiki/Engineering-guidelines#breaking-changes

cc @HaoK @ajcvickers
@Eilon Eilon added bug This issue describes a behavior which is not expected - a bug. 1 - Ready labels Mar 21, 2018
@Eilon Eilon added this to the 2.1.0-preview2 milestone Mar 21, 2018
@Eilon Eilon changed the title Undo breaking change for OptionsWrapper<T>.Remove(string) Undo breaking change for OptionsWrapper<T>.Remove(string) and Add(string, TOptions) Mar 21, 2018
@Eilon Eilon mentioned this issue Mar 21, 2018
Merged
@Eilon
Copy link
Member Author

Eilon commented Mar 21, 2018

See discussion here: aspnet/Options#251 (comment)

@HaoK HaoK self-assigned this Mar 26, 2018
@HaoK HaoK mentioned this issue Mar 26, 2018
Merged
@HaoK HaoK added Done This issue has been fixed and removed 1 - Ready labels Mar 26, 2018
@HaoK HaoK closed this as completed Mar 26, 2018
natemcmaster pushed a commit that referenced this issue Nov 15, 2018
@flash2048 @halter73
Use logical 'or' instead of bitwise in IsConnectionReset method. (#2983)
df2ad98
ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
@BrennanConroy
[TS] Wait for handshake response (#2983)
4dfd93c
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
2.1.0-preview2
Development

No branches or pull requests
2 participants
@Eilon @HaoK