Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copied static files code from WebView project #31078

Open
Eilon opened this issue Mar 19, 2021 · 3 comments
Open

Remove copied static files code from WebView project #31078

Eilon opened this issue Mar 19, 2021 · 3 comments
Labels
area-blazor Includes: Blazor, Razor Components clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors feature-blazor-desktop This issue is related to Blazor Desktop Pillar: Technical Debt Priority:3 Work that is nice to have

Comments

@Eilon
Copy link
Member

Eilon commented Mar 19, 2021

As a workaround for another problem we introduced a lot of copied code into the Blazor Desktop WebView package: #31071

There's a fair bit of copied code related to static files and content types. The Blazor Desktop packages can't depend on anything in Microsoft.AspNetCore.App because they have to run in places where ASP.NET Core doesn't run, such as Android and iOS.

Options:
0. Do nothing and keep the copied code (possibly trimming it down to the minimal amount needed, rather than taking entire files)

  1. Move the code to a NuGet package that can be used from everywhere
  2. Something else?
@Eilon Eilon added clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors feature-blazor-desktop This issue is related to Blazor Desktop labels Mar 19, 2021
@Eilon Eilon added this to the 6.0-preview4 milestone Mar 19, 2021
@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Mar 21, 2021
@Eilon
Copy link
Member Author

Eilon commented Apr 20, 2021

Ideas:

  1. Delete the copied code that does file extension mapping
  2. Instead, have an MSBuild-time target that computes the MIME types using an MSBuild item group that has all the MIME mappings
    • This would enable users to update/add/remove MIME types if they need something custom
  3. The MSBuild target would store the computed MIME types in some new asset
  4. In the WebViewManager code load the computed MIME types along with the list of embedded files and serve it up

We still need to figure out what to do with copied code for the static file provider that is itself copied, plus the path/query string code that is copied.

@Eilon Eilon modified the milestones: 6.0-preview4, 6.0-preview5 Apr 20, 2021
@ghost ghost added the Working label May 13, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0-preview7, 6.0-rc1 Jul 12, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0-rc1, 6.0-rc2 Aug 5, 2021
@Eilon Eilon modified the milestones: 6.0-rc2, .NET 7 Planning Sep 20, 2021
@Eilon Eilon removed their assignment Sep 20, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: .NET 7 Planning, Backlog Nov 11, 2021
@ghost
Copy link

ghost commented Nov 11, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ghost
Copy link

ghost commented Jan 3, 2024

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT added the Priority:3 Work that is nice to have label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components clean-up This issue is internal clean-up and has no effect on public APIs or expected behaviors feature-blazor-desktop This issue is related to Blazor Desktop Pillar: Technical Debt Priority:3 Work that is nice to have
Projects
None yet
Development

No branches or pull requests

4 participants