Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expect 100 continue logic in Kestrel to avoid doing sync over async #31225

Closed
davidfowl opened this issue Mar 25, 2021 · 2 comments · Fixed by #31650
Closed

Fix expect 100 continue logic in Kestrel to avoid doing sync over async #31225

davidfowl opened this issue Mar 25, 2021 · 2 comments · Fixed by #31650
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. feature-kestrel help wanted Up for grabs. We would accept a PR to help resolve this issue
Milestone

Comments

@davidfowl
Copy link
Member

Describe the bug

Though this doesn't cause any problems in practice (we believe), there's a code cleanup that needs to happen around expect 100 continue handling in Kestrel. The code paths ProduceContinue are called from are all asynchronous, yet the method is synchronous and does sync over async. Lets fix that finally.

Here's the code

@ghost
Copy link

ghost commented Mar 25, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@davidfowl davidfowl added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Mar 25, 2021
@davidfowl
Copy link
Member Author

@wtgodbe assigned this to you for the next preview.

@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2021
@danroth27 danroth27 added the bug This issue describes a behavior which is not expected - a bug. label May 14, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. feature-kestrel help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants