Use LoggerMessage.Define overloads that disable the IsEnabled check

[gfoidl]

Depends on dotnet/runtime#45290

There are some places that benefit from this change.

Everywhere logger.IsEnabled is checked, can profit by removing the double-check.

Then there are some places where "heavier objects" need to be created, even if logging is disabled for that level.
(Can use this regex search).

Just from the first results-page (didn't check all / exhaustive) e.g.:

aspnetcore/src/Mvc/Mvc.ViewFeatures/src/MvcViewFeaturesLoggerExtensions.cs

Lines 138 to 139 in 155f402

	var formattedArguments = GetFormattedArguments(arguments);
	_viewComponentExecuting(logger, context.ViewComponentDescriptor.DisplayName, formattedArguments, null);

[ghost]

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[gfoidl]

The runtime-PR dotnet/runtime#50334 got merged.
When will this change be available here? (so I can start to work on this).

[davidfowl]

Generally, you can look [here[(https://github.com/dotnet/aspnetcore/blob/main/eng/Version.Details.xml) to tell where any repo is at dependency wise. As of writing, we're here https://github.com/dotnet/aspnetcore/blob/d1403ac8ed19f9effd65062ab46e7bdaf37d8ea3/eng/Version.Details.xml#L282 for dotnet/runtime.

So we can do:

https://github.com/dotnet/runtime/commits/main?before=8cc37cb9d8405be0b15bdc8ae9cf2ddc31dbd998+35&branch=main

To see what's in there. The new APIs are available!

[gfoidl]

Great! I'll have a look into this over the weekend.

[davidfowl]

I've assigned it to you @gfoidl