Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SlabMemoryPool #31609

Closed
JamesNK opened this issue Apr 8, 2021 · 1 comment · Fixed by #31752
Closed

Rename SlabMemoryPool #31609

JamesNK opened this issue Apr 8, 2021 · 1 comment · Fixed by #31752
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue task
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Apr 8, 2021

The SlabMemoryPool no longer use slabs - #30732 - and should be renamed.

Possible new name: PinnedBlockMemoryPool

@davidfowl

@JamesNK JamesNK added help wanted Up for grabs. We would accept a PR to help resolve this issue area-runtime good first issue Good for newcomers. labels Apr 8, 2021
@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Apr 9, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

BrennanConroy pushed a commit that referenced this issue Apr 14, 2021
@danroth27 danroth27 added the task label May 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 13, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants