Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid RZ Diagnostic Location #31783

Closed
TanayParikh opened this issue Apr 13, 2021 · 4 comments · Fixed by dotnet/sdk#17204
Closed

Invalid RZ Diagnostic Location #31783

TanayParikh opened this issue Apr 13, 2021 · 4 comments · Fixed by dotnet/sdk#17204
Labels
area-razor.compiler This issue is related to the Razor compiler (now external) bug This issue describes a behavior which is not expected - a bug.
Milestone

Comments

@TanayParikh
Copy link
Contributor

TanayParikh commented Apr 13, 2021

Not sure if this falls under tooling or runtime so tagged both for now.

image

The columns (ex. column 1131 for the first diagnostic) are non-existent..

Repro:

  1. Build the E2E tests project
  2. Get RZ9991 errors with invalid Column numbers (note you'll have to right click on the header to see the column numbers)
  3. Clicking on the diagnostic takes you to the far right of the page beyond any characters.
@TanayParikh TanayParikh added bug This issue describes a behavior which is not expected - a bug. area-runtime labels Apr 13, 2021
@TanayParikh
Copy link
Contributor Author

Note; errors are due to: #31023

@pranavkm pranavkm added area-razor.compiler This issue is related to the Razor compiler (now external) and removed area-runtime labels Apr 13, 2021
@captainsafia
Copy link
Member

The diagnostics are coming from the generated source files, not the user's source files, which is likely why the column numbers are off.

This brings up a general inquiry I've had about how build errors get displayed to the users. Now that generated files are not emitted by default, it is difficult for the user to be able to open a file and see where the exception is coming from.

It might be helpful to figure out how to map the diagnostics in the generated source to the appropriate lines in the original source files.

@captainsafia captainsafia added this to the Next sprint planning milestone Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@benaadams
Copy link
Member

Might be resolved by dotnet/sdk#17204

@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2021
@dotnet dotnet unlocked this conversation Oct 8, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-razor.compiler This issue is related to the Razor compiler (now external) bug This issue describes a behavior which is not expected - a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants