Use correct column number for Razor #17204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Aside the source generator is so much faster at compiling than the previous method 💜 |
|
Made test fix |
captainsafia
approved these changes
Apr 26, 2021
|
Is it too late to get this into preview4 since it causes compile errors? |
|
Unfortunately, we missed the cutoff for preview4 with this one so it'll have to land in preview5. |
ViktorHofer
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Razor compile errors that are dependant on column position (e.g. "directive must be at start of line")
Fixes dotnet/aspnetcore#32154
Fixes dotnet/aspnetcore#31783
/cc @captainsafia