Use CultureInfo.InvariantCulture when TryParsing minimal action parameters

[halter73]

Follow up to #30248 (comment):

• Look for TryParse on method on any parameter first, signatures supported:
  • Special case for some built-in types:
    • ex: static bool TryParse(string, NumberStyles, IFormatProvider, int) where the NumberStyles parameter is required to use CultureInfo.InvariantCulture as the IFormatProvider.
  • static bool TryParse(string, IFormatProvider, out T)
• Use invariant culture always

[ghost]

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[halter73]

Here's a list of TryParse methods I found taking an IFormatProvider:

Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, System.Decimal ByRef)
Boolean TryParse[TEnum](System.String, Boolean, TEnum ByRef)
Boolean TryParse(System.String, System.IFormatProvider, System.Globalization.DateTimeStyles, System.DateTime ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, Byte ByRef)
Boolean TryParse(System.String, System.IFormatProvider, System.Globalization.DateTimeStyles, System.DateTimeOffset ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, Double ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, System.Half ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, Int16 ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, Int32 ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, Int64 ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, IntPtr ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, SByte ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, Single ByRef)
Boolean TryParse(System.String, System.IFormatProvider, System.TimeSpan ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, UInt16 ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, UInt32 ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, UInt64 ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, UIntPtr ByRef)
Boolean TryParse(System.String, System.String, System.Diagnostics.ActivityContext ByRef)
Boolean TryParse(System.String, System.Globalization.NumberStyles, System.IFormatProvider, System.Numerics.BigInteger ByRef)

I just ran something like the following in dotnet interactive:

using System.Reflection;

var assemblies = AppDomain.CurrentDomain.GetAssemblies();
var types = assemblies.SelectMany(a => a.GetTypes()).ToArray();
var staticMethods = types.SelectMany(t => t.GetMethods(BindingFlags.Public | BindingFlags.Static)).ToArray();

bool IsTryParseMethod(MethodInfo method)
{
    if (method.Name != "TryParse" || method.ReturnType != typeof(bool))
    {
        return false;
    }

    var tryParseParameters = method.GetParameters();

    if (tryParseParameters.Length > 2 &&
        tryParseParameters[0].ParameterType == typeof(string))
    {
        return true;
    }

    return false;
}

var tryParseMethods = staticMethods.Where(IsTryParseMethod).ToArray();
tryParseMethods.Select(m => m.ToString())

[wcontayon]

Hi @halter73 can I try a PR on that 🙂 ?

[halter73]

Absolutely! Thanks again for the null handling PR. Feel free to open a draft early or comment here if you have any questions or concerns.