Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CultureInfo.InvariantCulture when TryParsing minimal action parameters #33624

Merged
9 commits merged into from
Jun 28, 2021
Merged

Use CultureInfo.InvariantCulture when TryParsing minimal action parameters #33624

9 commits merged into from
Jun 28, 2021

Conversation

wcontayon
Copy link
Contributor

@wcontayon wcontayon commented Jun 17, 2021 •
edited
Loading

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

CultureInfo.InvariantCulture when TryParsing minimal action parameters

Addresses #32377

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jun 17, 2021
@wcontayon wcontayon marked this pull request as ready for review June 18, 2021 20:55
@wcontayon wcontayon requested a review from Pilchie as a code owner June 19, 2021 22:32
@wcontayon wcontayon requested a review from halter73 June 20, 2021 21:05
@wcontayon wcontayon requested a review from halter73 June 25, 2021 22:01
halter73
halter73 reviewed Jun 26, 2021
View reviewed changes
src/Shared/TryParseMethodCache.cs

var tryParseParameters = method.GetParameters();
methodInfo = type.GetMethod("TryParse", BindingFlags.Public | BindingFlags.Static, new[] { typeof(string), typeof(IFormatProvider), type.MakeByRefType() });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test with a custom type that implements this signature and verify it actually gets called with CultureInfo.InvariantCulture?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure ! 🙂

@halter73
Copy link
Member

This is looking really good! Can you undo the src/submodules/googletest update?

@wcontayon wcontayon requested a review from halter73 June 26, 2021 21:51
@ghost
Copy link

ghost commented Jun 28, 2021

Hello @halter73!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5c78265 into dotnet:main Jun 28, 2021
@halter73
Copy link
Member

Thanks @wcontayon!

@halter73 halter73 added this to the 6.0-preview7 milestone Jun 28, 2021
@wcontayon
Copy link
Contributor Author

Thanks @wcontayon!

You're welcome @halter73 🙂

@ghost
Copy link

ghost commented Jun 28, 2021

Hi @wcontayon. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@wcontayon wcontayon deleted the use_cultureInvariant_parse_mininalAction_params_#32377 branch July 1, 2021 22:52
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

@halter73 halter73

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@wcontayon @halter73 @amcasey