Publishing on GitHub breaks with .Net 6 preview7 sdk #35274
Comments
mkArtakMSFT
added
area-blazor
|
@MarkStega thanks for contacting us. Can you produce a flat list of the files? Is incredibly hard to spot the differences like that |
|
Here are the files as properly published using the P6 SDK: |
|
And here are the files improperly published by the P7 SDK: |
|
I want to stress that the only difference between these two artifacts is that one is produced using the P6 SDK & the other the P7 SDK during a github actions build. The repository is available at https://github.com/Material-Blazor/Material.Blazor |
|
@MarkStega the P6 files seem to be missing, i'm trying to do a diff of the two and see what's going on. |
|
Here is the diff between preview6 and preview7 diff --git "a/.\\p6.txt" "b/.\\p7.txt"
index ba2b3c2..f82a0f3 100644
--- "a/.\\p6.txt"
+++ "b/.\\p7.txt"
@@ -1,16 +1,22 @@
+package-lock.json
web.config
wwwroot\.nojekyll
wwwroot\404.html
wwwroot\index.html
wwwroot\manifest.json
+wwwroot\Material.css
+wwwroot\Material.min.css
+wwwroot\MaterialBlazor.css
+wwwroot\MaterialBlazor.js
+wwwroot\MaterialBlazor.min.css
+wwwroot\MaterialBlazor.min.js
wwwroot\service-worker-assets.js
wwwroot\service-worker.js
-wwwroot\_content\Material.Blazor\Material.css
-wwwroot\_content\Material.Blazor\Material.min.css
-wwwroot\_content\Material.Blazor\MaterialBlazor.css
-wwwroot\_content\Material.Blazor\MaterialBlazor.js
-wwwroot\_content\Material.Blazor\MaterialBlazor.min.css
-wwwroot\_content\Material.Blazor\MaterialBlazor.min.js
+wwwroot\css\asymmetric-theme.min.css
+wwwroot\css\dark-square-theme.min.css
+wwwroot\css\light-square-theme.min.css
+wwwroot\css\material-default-theme.min.css
+wwwroot\css\rounded-theme.min.css
wwwroot\_content\Material.Blazor.Website\.nojekyll
wwwroot\_content\Material.Blazor.Website\404.html
wwwroot\_content\Material.Blazor.Website\android-chrome-192x192.png
@@ -22,11 +28,6 @@ wwwroot\_content\Material.Blazor.Website\favicon-32x32.png
wwwroot\_content\Material.Blazor.Website\favicon.ico
wwwroot\_content\Material.Blazor.Website\favicon.png
wwwroot\_content\Material.Blazor.Website\icon-512.png
-wwwroot\_content\Material.Blazor.Website\css\asymmetric-theme.min.css
-wwwroot\_content\Material.Blazor.Website\css\dark-square-theme.min.css
-wwwroot\_content\Material.Blazor.Website\css\light-square-theme.min.css
-wwwroot\_content\Material.Blazor.Website\css\material-default-theme.min.css
-wwwroot\_content\Material.Blazor.Website\css\rounded-theme.min.css
wwwroot\_content\Material.Blazor.Website\images\architecture-book-shelves-books-commercial-eatablishment-244134.jpg
wwwroot\_content\Material.Blazor.Website\images\book-shelves.jpg
wwwroot\_content\Material.Blazor.Website\images\mac.jpg
@@ -43,25 +44,24 @@ wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typ
wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typing-on-a-keyboard-9692.mp4
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.jpg
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.mp4
-wwwroot\_framework\binding_support.js
wwwroot\_framework\blazor.boot.json
wwwroot\_framework\blazor.webassembly.js
-wwwroot\_framework\corebindings.c
-wwwroot\_framework\dotnet.6.0.0-preview.6.21352.12.js
+wwwroot\_framework\blazor.webassembly.js.gz
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js.gz
wwwroot\_framework\dotnet.timezones.blat
wwwroot\_framework\dotnet.wasm
-wwwroot\_framework\dotnet_support.js
-wwwroot\_framework\driver.c
-wwwroot\_framework\emcc-default.rsp
-wwwroot\_framework\Emcc.props
+wwwroot\_framework\dotnet.wasm.gz
wwwroot\_framework\icudt.dat
wwwroot\_framework\icudt_CJK.dat
wwwroot\_framework\icudt_EFIGS.dat
wwwroot\_framework\icudt_no_CJK.dat
-wwwroot\_framework\library_mono.js
wwwroot\_framework\Material.Blazor.dll
+wwwroot\_framework\Material.Blazor.pdb.gz
wwwroot\_framework\Material.Blazor.Website.dll
+wwwroot\_framework\Material.Blazor.Website.pdb.gz
wwwroot\_framework\Material.Blazor.Website.WebAssembly.dll
+wwwroot\_framework\Material.Blazor.Website.WebAssembly.pdb.gz
wwwroot\_framework\Microsoft.AspNetCore.Components.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Forms.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Web.dll
@@ -78,10 +78,6 @@ wwwroot\_framework\Microsoft.Extensions.Primitives.dll
wwwroot\_framework\Microsoft.JSInterop.dll
wwwroot\_framework\Microsoft.JSInterop.WebAssembly.dll
wwwroot\_framework\Nager.Date.dll
-wwwroot\_framework\package-lock.json
-wwwroot\_framework\pal_random.js
-wwwroot\_framework\pinvoke.c
-wwwroot\_framework\pinvoke.h
wwwroot\_framework\System.Collections.Concurrent.dll
wwwroot\_framework\System.Collections.dll
wwwroot\_framework\System.Collections.Immutable.dll |
|
Seems like the prefix |
|
Could it actually be related to dotnet/sdk#19665? Seems like there is some handling of static assets depending on source type (is that file type?). That's broken entirely for net5, but maybe it's broken here too, because it seems that mostly js/css is affected, but not images. |
|
Figured out what's going on: The way the assets were being included in the project is not the way we recommend doing this and it was working thanks to an implementation detail, we've changed this on preview7 and as a side-effect the assets were not being picked up. The issue is that you are bundling CSS and JS and not declaring those as Content. The reason why that works is because static web assets before p7 did two evaluations, one during build (where your assets got generated) and another one when we called the project to collect the static web assets. What happened, is that we would see the results of the first build during this second evaluation and we would then include those. What we've changed is that the assets get produced during build and recorded into a manifest, and that's what we use to indicate referencing projects what assets are part of the project. That's more inline with what MSBuild does and what you would expect (you don't want different results between builds). The proper way to solve this is to hook in to static web assets to define the content. This can be done in two ways: <ResolveStaticWebAssetsInputsDependsOn>
_DefineMyAssets;
$(ResolveStaticWebAssetInputsDependsOn)
</ResolveStaticWebAssetInputsDependsOn> <Target Name="_MyStuff" BeforeTargets="ResolveProjectStaticWebAssets">
<ItemGroup>
<Content Include="..." />
</ItemGroup>
<Target>You can also add them to the content item group directly and we'll pick them up (they don't have to exist) so long as you don't include them twice (see below). With that, this is the diff that I get now diff --git "a/..\\diff\\p6.txt" "b/..\\diff\\p7WithFix.txt"
index ba2b3c2d..0c936084 100644
--- "a/..\\diff\\p6.txt"
+++ "b/..\\diff\\p7WithFix.txt"
@@ -1,4 +1,3 @@
-web.config
wwwroot\.nojekyll
wwwroot\404.html
wwwroot\index.html
@@ -43,25 +42,24 @@ wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typ
wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typing-on-a-keyboard-9692.mp4
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.jpg
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.mp4
-wwwroot\_framework\binding_support.js
wwwroot\_framework\blazor.boot.json
wwwroot\_framework\blazor.webassembly.js
-wwwroot\_framework\corebindings.c
-wwwroot\_framework\dotnet.6.0.0-preview.6.21352.12.js
+wwwroot\_framework\blazor.webassembly.js.gz
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js.gz
wwwroot\_framework\dotnet.timezones.blat
wwwroot\_framework\dotnet.wasm
-wwwroot\_framework\dotnet_support.js
-wwwroot\_framework\driver.c
-wwwroot\_framework\emcc-default.rsp
-wwwroot\_framework\Emcc.props
-wwwroot\_framework\icudt.dat
+wwwroot\_framework\dotnet.wasm.gz
wwwroot\_framework\icudt_CJK.dat
wwwroot\_framework\icudt_EFIGS.dat
wwwroot\_framework\icudt_no_CJK.dat
-wwwroot\_framework\library_mono.js
+wwwroot\_framework\icudt.dat
wwwroot\_framework\Material.Blazor.dll
+wwwroot\_framework\Material.Blazor.pdb.gz
wwwroot\_framework\Material.Blazor.Website.dll
-wwwroot\_framework\Material.Blazor.Website.WebAssembly.dll
+wwwroot\_framework\Material.Blazor.Website.pdb.gz
+wwwroot\_framework\Material.Blazor.WebSite.WebAssembly.dll
+wwwroot\_framework\Material.Blazor.WebSite.WebAssembly.pdb.gz
wwwroot\_framework\Microsoft.AspNetCore.Components.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Forms.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Web.dll
@@ -78,10 +76,6 @@ wwwroot\_framework\Microsoft.Extensions.Primitives.dll
wwwroot\_framework\Microsoft.JSInterop.dll
wwwroot\_framework\Microsoft.JSInterop.WebAssembly.dll
wwwroot\_framework\Nager.Date.dll
-wwwroot\_framework\package-lock.json
-wwwroot\_framework\pal_random.js
-wwwroot\_framework\pinvoke.c
-wwwroot\_framework\pinvoke.h
wwwroot\_framework\System.Collections.Concurrent.dll
wwwroot\_framework\System.Collections.dll
wwwroot\_framework\System.Collections.Immutable.dll
diff --git "a/..\\diff\\p6.txt" "b/..\\diff\\p7WithFix.txt"
index ba2b3c2d..0c936084 100644
--- "a/..\\diff\\p6.txt"
+++ "b/..\\diff\\p7WithFix.txt"
@@ -1,4 +1,3 @@
-web.config
wwwroot\.nojekyll
wwwroot\404.html
wwwroot\index.html
@@ -43,25 +42,24 @@ wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typ
wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typing-on-a-keyboard-9692.mp4
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.jpg
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.mp4
-wwwroot\_framework\binding_support.js
wwwroot\_framework\blazor.boot.json
wwwroot\_framework\blazor.webassembly.js
-wwwroot\_framework\corebindings.c
-wwwroot\_framework\dotnet.6.0.0-preview.6.21352.12.js
+wwwroot\_framework\blazor.webassembly.js.gz
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js.gz
wwwroot\_framework\dotnet.timezones.blat
wwwroot\_framework\dotnet.wasm
-wwwroot\_framework\dotnet_support.js
-wwwroot\_framework\driver.c
-wwwroot\_framework\emcc-default.rsp
-wwwroot\_framework\Emcc.props
-wwwroot\_framework\icudt.dat
+wwwroot\_framework\dotnet.wasm.gz
wwwroot\_framework\icudt_CJK.dat
wwwroot\_framework\icudt_EFIGS.dat
wwwroot\_framework\icudt_no_CJK.dat
-wwwroot\_framework\library_mono.js
+wwwroot\_framework\icudt.dat
wwwroot\_framework\Material.Blazor.dll
+wwwroot\_framework\Material.Blazor.pdb.gz
wwwroot\_framework\Material.Blazor.Website.dll
-wwwroot\_framework\Material.Blazor.Website.WebAssembly.dll
+wwwroot\_framework\Material.Blazor.Website.pdb.gz
+wwwroot\_framework\Material.Blazor.WebSite.WebAssembly.dll
+wwwroot\_framework\Material.Blazor.WebSite.WebAssembly.pdb.gz
wwwroot\_framework\Microsoft.AspNetCore.Components.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Forms.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Web.dll
@@ -78,10 +76,6 @@ wwwroot\_framework\Microsoft.Extensions.Primitives.dll
wwwroot\_framework\Microsoft.JSInterop.dll
wwwroot\_framework\Microsoft.JSInterop.WebAssembly.dll
wwwroot\_framework\Nager.Date.dll
-wwwroot\_framework\package-lock.json
-wwwroot\_framework\pal_random.js
-wwwroot\_framework\pinvoke.c
-wwwroot\_framework\pinvoke.h
wwwroot\_framework\System.Collections.Concurrent.dll
wwwroot\_framework\System.Collections.dll
wwwroot\_framework\System.Collections.Immutable.dll
diff --git "a/..\\diff\\p6.txt" "b/..\\diff\\p7WithFix.txt"
index ba2b3c2d..0c936084 100644
--- "a/..\\diff\\p6.txt"
+++ "b/..\\diff\\p7WithFix.txt"
@@ -1,4 +1,3 @@
-web.config
wwwroot\.nojekyll
wwwroot\404.html
wwwroot\index.html
@@ -43,25 +42,24 @@ wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typ
wwwroot\_content\Material.Blazor.Website\videos\coverr-close-up-of-two-hands-typing-on-a-keyboard-9692.mp4
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.jpg
wwwroot\_content\Material.Blazor.Website\videos\coverr-someone-is-checking-emails-there_s-an-old-globe-on-the-table-0186.mp4
-wwwroot\_framework\binding_support.js
wwwroot\_framework\blazor.boot.json
wwwroot\_framework\blazor.webassembly.js
-wwwroot\_framework\corebindings.c
-wwwroot\_framework\dotnet.6.0.0-preview.6.21352.12.js
+wwwroot\_framework\blazor.webassembly.js.gz
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js
+wwwroot\_framework\dotnet.6.0.0-preview.7.21377.19.js.gz
wwwroot\_framework\dotnet.timezones.blat
wwwroot\_framework\dotnet.wasm
-wwwroot\_framework\dotnet_support.js
-wwwroot\_framework\driver.c
-wwwroot\_framework\emcc-default.rsp
-wwwroot\_framework\Emcc.props
-wwwroot\_framework\icudt.dat
+wwwroot\_framework\dotnet.wasm.gz
wwwroot\_framework\icudt_CJK.dat
wwwroot\_framework\icudt_EFIGS.dat
wwwroot\_framework\icudt_no_CJK.dat
-wwwroot\_framework\library_mono.js
+wwwroot\_framework\icudt.dat
wwwroot\_framework\Material.Blazor.dll
+wwwroot\_framework\Material.Blazor.pdb.gz
wwwroot\_framework\Material.Blazor.Website.dll
-wwwroot\_framework\Material.Blazor.Website.WebAssembly.dll
+wwwroot\_framework\Material.Blazor.Website.pdb.gz
+wwwroot\_framework\Material.Blazor.WebSite.WebAssembly.dll
+wwwroot\_framework\Material.Blazor.WebSite.WebAssembly.pdb.gz
wwwroot\_framework\Microsoft.AspNetCore.Components.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Forms.dll
wwwroot\_framework\Microsoft.AspNetCore.Components.Web.dll
@@ -78,10 +76,6 @@ wwwroot\_framework\Microsoft.Extensions.Primitives.dll
wwwroot\_framework\Microsoft.JSInterop.dll
wwwroot\_framework\Microsoft.JSInterop.WebAssembly.dll
wwwroot\_framework\Nager.Date.dll
-wwwroot\_framework\package-lock.json
-wwwroot\_framework\pal_random.js
-wwwroot\_framework\pinvoke.c
-wwwroot\_framework\pinvoke.h
wwwroot\_framework\System.Collections.Concurrent.dll
wwwroot\_framework\System.Collections.dll
wwwroot\_framework\System.Collections.Immutable.dll |
|
I chose the second method and indeed the github actions build now works. However when I try to run the website project from Visual Studio I get the following output from dotnet.exe: Unhandled exception. System.ArgumentException: An item with the same key has already been added. Key: Material.css |
|
@MarkStega It's likely that you are including the content twice. That is because the first time you build the content doesn't exist and the second time you build it already exists. You can still use the approach I mentioned, but you need to make sure it's not already there. The simplest way I can think of is: |
|
With this in place in Material.Blazor.csproj and Material.Blazor.Website.csproj I can run locally and in the gh action Thanks very much for all of the help; this was pretty subtle. |
|
@MarkStega No problem, we'll improve the documentation in this area to suggest better patterns to follow. |
|
Based on the feedback here, we plan to see if we can make this scenario easier in .NET 7.0 and we've created an experimental package you can use to integrate JS tooling easier into the build pipeline. We have a sample here and we'll be publishing a blog post with more details in a few days. The TL;DR is:
We will invoke |
|
Closing this issue since we have created a sample to achieve this and a blog post that will be available in the following days and which we will include in docs. |
ghost
locked as resolved and limited conversation to collaborators
Describe the bug
I have a repository that produces a static website using github pages. It is based upon .net 6 P6; When I build and publish using the p6 sdk everything works; However, if I let the sdk 'float' to the p7 sdk the publish step does not move all of the content to the appropriate locations. Look at the content of wwwroot in each case. The only difference is the sdk specified in the yml action file. The directory listings are from artifacts produced during the build and moved to my local machine.
The build steps are
Content produced with the p6 sdk:
Content produced by the p7 sdk:
What is very odd is that when I run the same commands locally on my Windows10 system they work as expected with the P7 SDK. Something in the Github actions environment using a windows job step is different and trips the P7 SDK during publish.
To Reproduce
Exceptions (if any)
Further technical details
VS2022 P3
The text was updated successfully, but these errors were encountered: