-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert projects in this repo to use ProjectReference #4246
Comments
cc @jkotalik who is helping do this for src/IISIntegration/ |
Once I get this done for IISIntegration, I'll do other repos too. IISIntegration was significantly more difficult to port than other repos (due to native dependencies). |
I'm adding a checklist to the original issue to track the groups of subrepos that we need to convert. Let's start by doing these one at a time. |
FYI - here is the script I've been using to convert Project/Package refs to just https://gist.github.com/natemcmaster/40556be8f8d821a225f48afbd743bbeb Usage: PS> Get-ChildItem *.csproj -Recurse | % { C:\src\scripts\mk_ref.ps1 $_ } |
Once #4954 is merged and makes its way up to master, I think we should be unblocked to convert Components and Mvc. FYI @SteveSandersonMS @javiercn - the refactoring on Components is likely to be fairly disruptive. Do you have any big changes that need to go in this week? |
Thanks for the heads-up, @natemcmaster! I’d definitely like to merge #5166 before any other disruptive change goes in. Should be ready to merge as soon as it’s reviewed. |
@natemcmaster #5166 is merged now, so you should be OK to do changes to Components to use |
@SteveSandersonMS I started looking into this but found code in src/Components/ that I'm unsure about, specifically, the code in src/Components/blazor/. Can you take a look at the details I posted in this comment? https://github.com/aspnet/AspNetCore-Internal/issues/1535#issuecomment-450685185 |
Part of #4246 Changes: * Update source code layout to follow the new conventions for this repo * Update project files to use `<Reference>` * Update targets to build NPM packages * Update BuildTools to support custom 'restore' and 'test' targets
This addresses #4246 for src/Components/. A few other changes were necessary because components had been using stale dependencies.
Follow-up to #3598.
The first phase of reducing repos was to merge the source code into a single repo. The second phase is to convert them from isolated folders of code with PackageReference across repo boundaries, to projects which use
ProjectReference
.We've already started some of this work. See #4013 for example and https://github.com/aspnet/AspNetCore/tree/master/src/DataProtection.
As done in #4013, we implement this using
<Reference>
items in .csproj and custom Reference resolution targets. This is done so we can automatically pick the right versions of assemblies to used based on conditions such as, is this a test project? is this branch building a patch or a new minor release? what versions were used in the last stable release? etc.See also https://github.com/aspnet/specs/blob/master/runtime/design-notes/2018-10-03-mondo-source-org.md for the spec on source code organization.
Repo groups to convert
The text was updated successfully, but these errors were encountered: