-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse named pipe endpoint from URL with BindingAddress #45056
Comments
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
Or just PipeName or NamedPipe? |
Thanks for contacting us. We're moving this issue to the |
API Review Notes:
namespace Microsoft.AspNetCore.Http;
public class BindingAddress
{
+ public bool IsNamedPipe { get; }
+ public string NamedPipeName { get; }
} API Approved! |
Done with #44426 |
Background and Motivation
Named pipe endpoints should be parsable from Kestrel url arg.
Proposed API
Usage Examples
Alternative Designs
There are
IsUnixPipe
andUnixPipePath
properties already on this type. Is "Named" vs "Unix" clear enough about which is which? We refer to them as name pipes everywhere else.Named pipes have a format for the name, e.g.
\\.\pipe\PipeName
- https://learn.microsoft.com/en-us/windows/win32/ipc/pipe-names. I chose not to use it, and simply anything afterpipe:
is the pipe name. This is consistent withunix:/
for UDS and keeps the URL simpler.If we did use the known format, then the usage example would look like this:
public string NamedPipePath { get; }
could be changed topublic string NamedPipeName { get; }
.NamedPipeName
is a little awkward, but more accurate to named pipe terms.Risks
The text was updated successfully, but these errors were encountered: