Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F# webapi template tests #46700

Open
JamesNK opened this issue Feb 16, 2023 · 4 comments
Open

Add F# webapi template tests #46700

JamesNK opened this issue Feb 16, 2023 · 4 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. feature-templates fsharp Used to flag F# template changes for review by area experts
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Feb 16, 2023

A change to the F# template - #46443 - broke the installer build - dotnet/installer#15564 (comment)

ItCanCreateAndBuildTemplatesWithDefaultFramework(templateName: "webapi", language: "F#")

Expected command to pass but it did not.
File Name: /__w/1/s/artifacts/bin/redist/Debug/dotnet/dotnet
Arguments: build        --framework net8.0 /p:_NETCoreSdkIsPreview=true
WorkingDir:: /__w/1/s/artifacts/bin/EndToEnd.Tests/Debug/net8.0/Tests/EndToEnd.Tests/TestTemplateCreateAndBuildwebapi[F#]
Exit Code: 1
StdOut:
MSBuild version 17.6.0-preview-23115-01+dfd8f413a for .NET
  Determining projects to restore...
  Restored /__w/1/s/artifacts/bin/EndToEnd.Tests/Debug/net8.0/Tests/EndToEnd.Tests/TestTemplateCreateAndBuildwebapi[F#]/TestTemplateCreateAndBuildwebapi[F#].fsproj (in 278 ms).
/__w/1/s/artifacts/bin/redist/Debug/dotnet/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(287,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/__w/1/s/artifacts/bin/EndToEnd.Tests/Debug/net8.0/Tests/EndToEnd.Tests/TestTemplateCreateAndBuildwebapi[F#]/TestTemplateCreateAndBuildwebapi[F#].fsproj]
/__w/1/s/artifacts/bin/EndToEnd.Tests/Debug/net8.0/Tests/EndToEnd.Tests/TestTemplateCreateAndBuildwebapi[F#]/Controllers/WeatherForecastController.fs(9,42): error FS0039: The type 'ILogger' is not defined. [/__w/1/s/artifacts/bin/EndToEnd.Tests/Debug/net8.0/Tests/EndToEnd.Tests/TestTemplateCreateAndBuildwebapi[F#]/TestTemplateCreateAndBuildwebapi[F#].fsproj]

Build FAILED.

There should be tests for this template in our repo CI so we know if something has broken. Then we can change F# templates with confidence.

@JamesNK JamesNK added the bug This issue describes a behavior which is not expected - a bug. label Feb 16, 2023
@JamesNK JamesNK changed the title Add F# template tests Add F# webapi template tests Feb 16, 2023
@mkArtakMSFT mkArtakMSFT added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates fsharp Used to flag F# template changes for review by area experts feature-templates labels Feb 16, 2023
@mkArtakMSFT
Copy link
Member

@JamesNK did the merged PR (which introduce the break) get reverted?

@mkArtakMSFT
Copy link
Member

@KevinRansom FYI

@Nick-Stanton
Copy link
Member

@JamesNK did the merged PR (which introduce the break) get reverted?

#46695

@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Feb 28, 2023
@ghost
Copy link

ghost commented Feb 28, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. feature-templates fsharp Used to flag F# template changes for review by area experts
Projects
None yet
Development

No branches or pull requests

5 participants
@JamesNK @wtgodbe @Nick-Stanton @mkArtakMSFT and others