Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code from F# templates #46443

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Remove unnecessary code from F# templates #46443

merged 1 commit into from
Feb 8, 2023

Conversation

MaciekWin3
Copy link
Contributor

Remove unnecessary code from F# templates

Description

I recently started to experiment with F# and I noticed that some of the F# templates have some unnecessary usings and parameters in it.

@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Feb 3, 2023
@ghost
Copy link

ghost commented Feb 3, 2023

Thanks for your PR, @MaciekWin3. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dnfadmin
Copy link

dnfadmin commented Feb 3, 2023

CLA assistant check
All CLA requirements met.

Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

@mkArtakMSFT mkArtakMSFT self-assigned this Feb 7, 2023
@mkArtakMSFT mkArtakMSFT merged commit f58f954 into dotnet:main Feb 8, 2023
@ghost ghost added this to the 8.0-preview2 milestone Feb 8, 2023
kasperk81 added a commit to kasperk81/aspnetcore that referenced this pull request Feb 16, 2023
@MaciekWin3 MaciekWin3 deleted the update-fsharp-templates-branch branch March 12, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants