Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests WebDriverExtensions.Navigate argument noReload has no effect #46810

Open
surayya-MS opened this issue Feb 22, 2023 · 5 comments
Open
Labels
area-blazor Includes: Blazor, Razor Components good first issue Good for newcomers. help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team task
Milestone

Comments

@surayya-MS
Copy link
Member

surayya-MS commented Feb 22, 2023

WebDriverExtensions.Navigate argument noReload https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/E2ETest/Infrastructure/WebDriverExtensions/WebDriverExtensions.cs
was removed in #35414 and setting it doesn't have any effect.

Consider removing noReload argument.

@surayya-MS
Copy link
Member Author

surayya-MS commented Feb 22, 2023

This was mentioned in the #46727 (comment)

@surayya-MS surayya-MS added area-blazor Includes: Blazor, Razor Components test-fixed labels Feb 22, 2023
@surayya-MS surayya-MS mentioned this issue Feb 22, 2023
4 tasks
@mkArtakMSFT mkArtakMSFT added this to the .NET 8 Planning milestone Feb 23, 2023
@ghost
Copy link

ghost commented Feb 23, 2023

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@javiercn javiercn added help wanted Up for grabs. We would accept a PR to help resolve this issue good first issue Good for newcomers. labels Oct 4, 2023
@javiercn javiercn modified the milestones: .NET 8 Planning, Backlog Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@mkArtakMSFT mkArtakMSFT added help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team and removed help wanted Up for grabs. We would accept a PR to help resolve this issue labels Oct 28, 2023
@mkArtakMSFT mkArtakMSFT modified the milestones: Backlog, BlazorPlanning Nov 5, 2023
@MackinnonBuck MackinnonBuck modified the milestones: Planning: WebUI, Backlog Dec 4, 2023
@ghost
Copy link

ghost commented Dec 4, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
MattyLeslie added a commit to MattyLeslie/aspnetcore that referenced this issue Apr 11, 2024
MattyLeslie added a commit to MattyLeslie/aspnetcore that referenced this issue Apr 12, 2024
MattyLeslie added a commit to MattyLeslie/aspnetcore that referenced this issue Apr 15, 2024
MattyLeslie added a commit to MattyLeslie/aspnetcore that referenced this issue Apr 15, 2024
MattyLeslie added a commit to MattyLeslie/aspnetcore that referenced this issue Apr 16, 2024
@MattyLeslie
Copy link
Contributor

This should be closed after merged changes in #55143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components good first issue Good for newcomers. help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team task
Projects
None yet
Development

No branches or pull requests

7 participants
@javiercn @MackinnonBuck @wtgodbe @mkArtakMSFT @MattyLeslie @surayya-MS and others