Services injected with attribute derived from FromKeyedServicesAttribute appear as request body in swagger

[stevendarby]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

This is much like #50704 except for attributes derived from FromKeyedServicesAttribute. The fix for the previous issue only checked if the type was exactly FromKeyedServicesAttribute.

Expected Behavior

I'm hoping this could be changed to use something like IsAssignableTo/From so that it covers derived attributes too.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

Is there a workaround? e.g. some other "Ignore this" attribute I could apply to hide it?

[stevendarby]

P.S. I'd be happy to raise a PR if that would help its chances of getting into a 9.0.x release.

[stevendarby]

Workaround for swashbuckle, which works with the limited cases I have, but might not be generally applicable for everyone:

public class KeyedServicesFilter : IOperationFilter
{
    public void Apply(OpenApiOperation operation, OperationFilterContext context)
    {
        if (context.ApiDescription.HttpMethod != HttpMethods.Get)
        {
            return;
        }

        var parameter = context.MethodInfo
            .GetParameters()
            .FirstOrDefault(p => p.CustomAttributes.Any(c => c.AttributeType.IsAssignableTo(typeof(FromKeyedServicesAttribute))));

        if (parameter is not null)
        {
            operation.RequestBody = null;

            if (context.SchemaRepository.TryLookupByType(parameter.ParameterType, out var schema))
            {
                context.SchemaRepository.Schemas.Remove(schema.Reference.Id);
            }
        }
    }
}

[captainsafia]

PRs are still welcome for this. I dunno how common a pattern derived from the BCL's FromKeyedServicesAttribute is but the fix seems fairly small. Marking as help wanted.

[dotnet-policy-service]

Looks like this issue has been identified as a candidate for community contribution. If you're considering sending a PR for this issue, look for the Summary Comment link in the issue description. That comment has been left by an engineer on our team to help you get started with handling this issue. You can learn more about our Help Wanted process here