Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out ProblemDetails + System.Text.Json #6202

Closed
1 task
pranavkm opened this issue Dec 31, 2018 · 2 comments · Fixed by #11460
Closed
1 task

Figure out ProblemDetails + System.Text.Json #6202

pranavkm opened this issue Dec 31, 2018 · 2 comments · Fixed by #11460
Assignees
@pranavkm
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview7

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Dec 31, 2018 •
edited
Loading

  • - ProblemDetails relied on JsonExtensionAttribute to ensure that swagger document generators produced the correct JsonSchema. Since the attribute would no longer be available, we need to figure out an alternate way to describe this to document generators.
@pranavkm pranavkm mentioned this issue Dec 31, 2018
Merged
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 2, 2019
@jzabroski jzabroski mentioned this issue Feb 19, 2019
Closed
@khellang
Copy link
Member

  • Since the attribute would no longer be available, we need to figure out an alternate way to describe this to document generators.

Why can't inheritance be used for this?

@pranavkm
Copy link
Contributor Author

@khellang the tentative plan is to have an attribute that System.Text.Json understands and add support for it in swagger generators. Places like so:

@pranavkm pranavkm changed the title Follow up on Newtonsoft.Json removal from Microsoft.AspNetCore.Mvc Figure out ProblemDetails + System.Text.Json Apr 23, 2019
@pranavkm pranavkm self-assigned this Apr 23, 2019
@pranavkm pranavkm added 1 - Ready bug This issue describes a behavior which is not expected - a bug. labels Apr 23, 2019
@pranavkm pranavkm added this to the 3.0.0-preview6 milestone Apr 23, 2019
pranavkm added a commit that referenced this issue Jun 22, 2019
@pranavkm
Add JsonExtensionData to ProblemDetails
b65dc97 
Fixes #6202
@pranavkm pranavkm mentioned this issue Jun 22, 2019
Merged
pranavkm added a commit that referenced this issue Jun 24, 2019
@pranavkm
Add JsonExtensionData to ProblemDetails
bed3542 
Fixes #6202
@pranavkm pranavkm added Done This issue has been fixed and removed Working labels Jun 25, 2019
pranavkm added a commit that referenced this issue Jun 25, 2019
@pranavkm
Add JsonExtensionData to ProblemDetails (#11460)
397a27f 
* Add JsonExtensionData to ProblemDetails
Fixes #6202
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging a pull request may close this issue.

Add JsonExtensionData to ProblemDetails dotnet/aspnetcore
4 participants
@pranavkm @Eilon @khellang @mkArtakMSFT