-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Closed
Copy link
Labels
area-authIncludes: Authn, Authz, OAuth, OIDC, BearerIncludes: Authn, Authz, OAuth, OIDC, Bearerdesign-proposalThis issue represents a design proposal for a different issue, linked in the descriptionThis issue represents a design proposal for a different issue, linked in the descriptionhelp wantedUp for grabs. We would accept a PR to help resolve this issueUp for grabs. We would accept a PR to help resolve this issue
Milestone
Description
Summary
Likely due to an oversight, the tokenValue parameter exposed by the TokenExtensions.UpdateTokenValue() API isn't currently declared as a string?, even though this parameter is expected to be nullable (it's not null-guarded and it updates a dictionary entry for which values are deliberately nullable).
Motivation and goals
Fixing the signature would offer a better indication that the tokenValue parameter is actually nullable.
Risks / unknowns
This change only affects compilation (since nullable references are hints) and has no risk of runtime regression.
Examples
// Currently logs a CS8604 warning as `GetTokenValue()` returns a `string?`.
properties.UpdateTokenValue("refresh_token", result.Properties.GetTokenValue("refresh_token"));Metadata
Metadata
Assignees
Labels
area-authIncludes: Authn, Authz, OAuth, OIDC, BearerIncludes: Authn, Authz, OAuth, OIDC, Bearerdesign-proposalThis issue represents a design proposal for a different issue, linked in the descriptionThis issue represents a design proposal for a different issue, linked in the descriptionhelp wantedUp for grabs. We would accept a PR to help resolve this issueUp for grabs. We would accept a PR to help resolve this issue