Skip to content

Update RoutePatternFactory.Pattern to allow a list of parameter policies for a key #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JamesNK opened this issue Jan 11, 2019 · 3 comments
Closed

Update RoutePatternFactory.Pattern to allow a list of parameter policies for a key #6588

JamesNK opened this issue Jan 11, 2019 · 3 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Comments

@JamesNK
Copy link
Member

JamesNK commented Jan 11, 2019

RoutePatternFactory.Pattern takes dictionary for extra parameter policies.

Key = policy name
Value = policy

Because this is a dictionary, only one policy can be provided for a name. It would be useful to also support an enumerable of policies for a key.

Inspired by - #6587 (comment)

https://github.com/aspnet/AspNetCore/blob/14e606997f8ef409f0ead89c0eda972bd09f96ab/src/Http/Routing/src/Patterns/RoutePatternFactory.cs#L128-L155

// @rynowak
@rynowak
Copy link
Member

rynowak commented Jan 11, 2019

Seems like a good enhancement, is this blocking?

@JamesNK
Copy link
Member Author

JamesNK commented Jan 11, 2019

I don't think it is for the linked 2.2 patch

@rynowak
Copy link
Member

rynowak commented Jan 11, 2019

OK good, because I don't think we would patch this.

@JamesNK JamesNK mentioned this issue Jan 11, 2019
Merged
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 11, 2019
@JamesNK JamesNK closed this as completed Jan 12, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Eilon @JamesNK @rynowak and others