Fix non-parameter route constraints not called with endpoint routing for 2.2

[JamesNK]

Addresses #6544

Description

Route constraints that do not have a matching parameter in the pattern are not run when matching a request with endpoint routing.

In the route below the DomainMatchingConstraint will not be run when matching a request because domain is not a route parameter.

routes.MapRoute(
    "default",
    "{controller=Home}/{action=Index}/{id?}",
    constraints: new { domain = new DomainMatchingConstraint("example.com"), });

Customer Impact

Requests will get matched to unexpected endpoints, e.g. the wrong MVC action. The only easy workaround to the issue is for the customer to disable endpoint routing.

Regression?

This is a regression for customers who upgrade to ASP.NET Core 2.2 and set 2.2/latest compatibility in their Startup.cs.

Risk

The fix is a small change in how endpoints are built in MVC. Risk is incorrect logic or the introduction of a runtime error.

[JamesNK]

@natemcmaster I needed to add dependency projects to Mvc.sln. Should it not have them or has no one needed to add them until now?

[natemcmaster]

Should it not have them or has no one needed to add them until now?

More likely the second one. If people are restoring on command line and then opening VS, they may not see this. Also, they might not see these errors anymore if using the latest VS 2019 dogfood builds, which should soon have a fix for NU1105.

[natemcmaster]

Can you fill out the shiproom template and apply the servicing-consider label when its ready for shiproom to review?

[JamesNK]

🆙 📅

[natemcmaster]

Can you update eng/PatchConfig.props to list the packages which need to ship an update?

[dougbu]

@JamesNK in addition, please resolve the conflicts in the solution