Skip to content

Build C++ Client on macOS, Windows and Linux with CMake #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
BrennanConroy opened this issue Mar 21, 2019 · 6 comments
Closed
4 tasks done

Build C++ Client on macOS, Windows and Linux with CMake #8706

BrennanConroy opened this issue Mar 21, 2019 · 6 comments
Assignees
@BrennanConroy
Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-signalr Includes: SignalR clients and servers enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-client-c++ Related to the SignalR C++ client
Milestone
3.0.0-preview8

Comments

@BrennanConroy
Copy link
Member

BrennanConroy commented Mar 21, 2019 •
edited
Loading

Epic #5301

  • Works on Windows, Linux, and Mac
  • CI integration
  • Optional flag/define for building tests (off by default?)
  • ReadMe describing how to build/consume the client
@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Mar 21, 2019
This was referenced Mar 21, 2019
Closed
Closed
@BrennanConroy BrennanConroy added this to the 3.0.0-preview4 milestone Mar 21, 2019
@BrennanConroy BrennanConroy self-assigned this Mar 21, 2019
@analogrelay analogrelay added release-3.0 feature-client-c++ Related to the SignalR C++ client labels Mar 21, 2019
@analogrelay analogrelay mentioned this issue Mar 21, 2019
Closed
@analogrelay analogrelay changed the title C++ Client with CMake Build C++ Client on macOS, Windows and Linux with CMake Mar 21, 2019
@analogrelay
Copy link
Contributor

Pre-triage notes:

  • Not necessary for preview 5, suggest moving to a later preview.

@BrennanConroy
Copy link
Member Author

I'd argue this is good for preview4, I already have a draft PR 95% working for this, aspnet/SignalR-Client-Cpp#4

@analogrelay
Copy link
Contributor

Triage decision: We'll leave this in preview 5 but it's fine if it slips.

@analogrelay analogrelay added enhancement This issue represents an ask for new feature or an enhancement to an existing one and removed triage-review labels Apr 30, 2019
@analogrelay analogrelay added feature-client-c++ Related to the SignalR C++ client and removed feature-client-c++ Related to the SignalR C++ client labels May 21, 2019
@analogrelay analogrelay removed this from the 3.0.0-preview6 milestone May 21, 2019
@analogrelay analogrelay added this to the 3.0.0-preview7 milestone May 21, 2019
@analogrelay analogrelay modified the milestones: 3.0.0-preview7, Backlog May 30, 2019
@analogrelay
Copy link
Contributor

Let's see about getting this done in Preview 8 (though I think it's basically done?)

@analogrelay analogrelay modified the milestones: Backlog, 3.0.0-preview8 Jun 12, 2019
@BrennanConroy
Copy link
Member Author

Almost, there was some feedback I'd like to react to.

@BrennanConroy
Copy link
Member Author

Done via aspnet/SignalR-Client-Cpp#4

@BrennanConroy BrennanConroy added the accepted This issue has completed "acceptance" testing (including accessibility) label Jul 31, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrennanConroy BrennanConroy

Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-signalr Includes: SignalR clients and servers enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-client-c++ Related to the SignalR C++ client
Projects
None yet
Milestone
3.0.0-preview8
Development

No branches or pull requests
2 participants
@analogrelay @BrennanConroy