Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime support for Blazor attribute splatting #10357

Merged
merged 19 commits into from
May 29, 2019
Merged

Add runtime support for Blazor attribute splatting #10357

merged 19 commits into from
May 29, 2019

Commits on May 28, 2019

  1. Add basic tests for duplicate attributes

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    23f6ccb View commit details
    Browse the repository at this point in the history

  2. Add AddMultipleAttributes improve RTB 

    - Adds AddMultipleAttributes
- Fix RTB to de-dupe attributes
- Fix RTB behaviour with boxed EventCallback (#8336)
- Add lots of tests for new RTB behaviour and EventCallback
    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    4d5ced4 View commit details
    Browse the repository at this point in the history

  3. Harden EventCallback test 

    This was being flaky while I was running E2E tests locally, and it
wasn't using a resiliant equality comparison.
    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    630d5f6 View commit details
    Browse the repository at this point in the history

  4. Add new setting on ParameterAttribute 

    Adds the option to mark a parameter as an *extra* parameter. Why is this
on ParameterAttribute and not a new type? It makes sense to make it a
modifier on Parameter so you can use it both ways (explicitly set it, or
allow it to collect *extras*).

Added unit tests and validations for interacting with the new setting.
    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    b815d3c View commit details
    Browse the repository at this point in the history

  5. Add renderer tests for 'extra' parameters

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    ef3a2fa View commit details
    Browse the repository at this point in the history

  6. Refactor Diagnostics for more analyzers

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    c6aaf93 View commit details
    Browse the repository at this point in the history

  7. Simplify analyzer and fix CascadingParameter 

    This is the *easy way* to write an analyzer that looks at declarations.
The information that's avaialable from symbols is much more high level
than syntax. Much of what's in this code today is needed to reverse
engineer what the compiler does already. If you use symbols you get to
benefit from all of that.

Also added validation for cascading parameters to the analyzer that I
think was just missing due to oversight.

The overall design pattern here is what I've been converging on for the
ASP.NET Core analyzers as a whole, and it seems to scale really well.
    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    dae4214 View commit details
    Browse the repository at this point in the history

  8. Add analyzer for types

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    e0245e5 View commit details
    Browse the repository at this point in the history

  9. Add analyzer for uniqueness 

    This involved a refactor to run the analyzer per-type instead of
per-property.
    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    d1d8042 View commit details
    Browse the repository at this point in the history

  10. Fix project file

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    2342762 View commit details
    Browse the repository at this point in the history

  11. Adjust name

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    6d5794c View commit details
    Browse the repository at this point in the history

  12. PR feedback on PCE and more renames

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    77bf360 View commit details
    Browse the repository at this point in the history

  13. Remove unused parameter

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    9f3ffb5 View commit details
    Browse the repository at this point in the history

  14. Fix #10398

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    ccd5498 View commit details
    Browse the repository at this point in the history

  15. Add E2E test

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    30c3bfe View commit details
    Browse the repository at this point in the history

  16. Pranavs cool feedback

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    2341101 View commit details
    Browse the repository at this point in the history

  17. Optimize silent frame removal

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    f45975d View commit details
    Browse the repository at this point in the history

  18. code check

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    3d38b3b View commit details
    Browse the repository at this point in the history

  19. pr feedback

    Ryan Nowak committed May 28, 2019
    Configuration menu
    Copy the full SHA
    95832c6 View commit details
    Browse the repository at this point in the history