Small fixes for DatabaseErrorPageMiddleware #11062
Conversation
The main change here is to also allow public `HasTables` to be found. This will be removed once we get the new EF merged. The change to the migration makes it align with what we would generate, but I don't think has any functional impact on the tests. See also dotnet/efcore#16024 which (I really hope!)fixes the other failures once it makes it here.
ajcvickers
requested review from
smitpatel,
AndriySvyryd,
BrennanConroy and
dougbu
There was a problem hiding this comment.
Is all of this going away once we have an official build containing the dotnet/efcore#16024 fix? If so, I'd just as soon wait because we can manually run darc on the #10939 branch. Otherwise, looks fine.
|
@dougbu It's a chicken-and-egg situation. The current code in master won't build with the new EF, but we need the new EF to fix the other issues. By merging this to master, it should mean that everything works when the new EF flows through. We could wait until that happens and then edit that PR, but this way we don't need to do that. |
|
🆗 might save us an hour or two before 'master' builds cleanly… (https://dnceng.visualstudio.com/internal/_build/results?buildId=219152 hasn't even started its Windows job, I need to react, and #10939 needs to be PR validated) |
ghost
deleted the
amcasey
added
the
area-middleware
The main change here is to also allow public
HasTablesto be found. This will be removed once we get the new EF merged.The change to the migration makes it align with what we would generate, but I don't think has any functional impact on the tests.
See also dotnet/efcore#16024 which (I really hope!) fixes the other failures once it makes it here.