-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Http/2 CompleteAsync #11193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Jun 13, 2019
halter73
reviewed
Jun 13, 2019
halter73
reviewed
Jun 13, 2019
halter73
reviewed
Jun 13, 2019
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2StreamTests.cs
Show resolved
Hide resolved
halter73
reviewed
Jun 13, 2019
src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.FeatureCollection.cs
Show resolved
Hide resolved
Tratcher
commented
Jun 13, 2019
JamesNK
reviewed
Jun 13, 2019
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2StreamTests.cs
Show resolved
Hide resolved
halter73
approved these changes
Jun 14, 2019
jkotalik
approved these changes
Jun 14, 2019
JamesNK
approved these changes
Jun 14, 2019
Tratcher
force-pushed
the
tratcher/complete
branch
from
June 14, 2019 22:12
c41294b
to
8ca6917
Compare
amcasey
added
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
and removed
area-runtime
labels
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10886 Adding IHttpResponseCompletionFeature.CompleteAsync for HTTP/2 only.
Retrofitting this for HTTP/1.1 shouldn't be hard but I wanted to unblock the gRPC scenarios first.
While testing this I fixed a bug in response trailers where they were not getting cleared if the app threw an exception and the server converted it to a 500 response. You'd end up with a 500 + trailers.