Skip to content

Expand Blazor logging #11919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 8, 2019
Merged

Expand Blazor logging #11919

merged 21 commits into from
Jul 8, 2019

Conversation

SteveSandersonMS
Copy link
Member

Implementation for #11792, except for the JS interop parts which @javiercn is handling.

@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Jul 5, 2019
@SteveSandersonMS SteveSandersonMS added this to the 3.0.0-preview8 milestone Jul 5, 2019
javiercn
javiercn approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward change!

I'm not uber familiar with the define pattern for the Log class, but I assume you've followed previous established practices.

pranavkm
pranavkm reviewed Jul 5, 2019
View reviewed changes
rynowak
rynowak reviewed Jul 5, 2019
View reviewed changes
rynowak
rynowak reviewed Jul 5, 2019
View reviewed changes
Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far 👍

BrennanConroy
BrennanConroy reviewed Jul 5, 2019
View reviewed changes
rynowak
rynowak approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@SteveSandersonMS SteveSandersonMS merged commit 6534bcf into master Jul 8, 2019
@ghost ghost deleted the stevesa/more-logging branch July 8, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

@BrennanConroy BrennanConroy BrennanConroy left review comments

@pranavkm pranavkm pranavkm approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
3.0.0-preview8
Development

Successfully merging this pull request may close these issues.
5 participants
@SteveSandersonMS @pranavkm @rynowak @javiercn @BrennanConroy