Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding to 2.2.7 #12100

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Update branding to 2.2.7 #12100

merged 3 commits into from
Jul 12, 2019

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Jul 11, 2019

No description provided.

dougbu added 2 commits July 11, 2019 13:17

Verified

This commit was signed with the committer’s verified signature.
dougbu Doug Bunting
- document changes to dependencies.props
- reflect changes in how Templating is handled
  - e.g. use EF Core examples

nit:
- adjust indentation to avoid markdown warnings

Verified

This commit was signed with the committer’s verified signature.
dougbu Doug Bunting
@dougbu dougbu requested review from pranavkm and a team July 11, 2019 20:21
@@ -2,7 +2,7 @@
<Project>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavkm Microsoft.AspNetCore.Mvc.Api.Analyzers is not listed in this file nor in Baseline.xml. Should it be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not sure what this file is. We published an update to the package already, didn't we? https://www.nuget.org/packages/Microsoft.AspNetCore.Mvc.Api.Analyzers/2.2.6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and Baseline.xml describe the package versions to use when the package is not updated in a particular patch. Since we're not planning to build Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj in this coming patch, should we ensure Mvc.Api.Analyzers.Test.csproj tests what we shipped last time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we ensure Mvc.Api.Analyzers.Test.csproj tests what we shipped last time?

If that's what we do for all other packages, that sounds like the reasonable thing to do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougbu
Copy link
Member Author

dougbu commented Jul 11, 2019

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com.

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2656
https://github.com/aspnet/AspNetCore-Internal/issues/2409

Verified

This commit was signed with the committer’s verified signature.
dougbu Doug Bunting
@dougbu dougbu merged commit 4fd1d01 into release/2.2 Jul 12, 2019
@ghost ghost deleted the dougbu/2.2.7.branding branch July 12, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants