-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branding to 2.2.7 #12100
Update branding to 2.2.7 #12100
Conversation
- document changes to dependencies.props - reflect changes in how Templating is handled - e.g. use EF Core examples nit: - adjust indentation to avoid markdown warnings
@@ -2,7 +2,7 @@ | |||
<Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavkm Microsoft.AspNetCore.Mvc.Api.Analyzers is not listed in this file nor in Baseline.xml. Should it be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not sure what this file is. We published an update to the package already, didn't we? https://www.nuget.org/packages/Microsoft.AspNetCore.Mvc.Api.Analyzers/2.2.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and Baseline.xml describe the package versions to use when the package is not updated in a particular patch. Since we're not planning to build Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj in this coming patch, should we ensure Mvc.Api.Analyzers.Test.csproj tests what we shipped last time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we ensure Mvc.Api.Analyzers.Test.csproj tests what we shipped last time?
If that's what we do for all other packages, that sounds like the reasonable thing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. See https://github.com/aspnet/AspNetCore/pull/12100/files#diff-96fa7dcb9c7726743838f28cc9629998R652 (an automatic addition) and https://github.com/aspnet/AspNetCore/pull/12100/files#diff-c763c910a1518ee2bfcbe97d4e86a6bcR77 (manually added but version updated correctly and automatically)
This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com. I've triaged the above build. I've created/commented on the following issue(s) |
No description provided.