Skip to content

Update sample applications to use public [Parameter]s. #12257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Update sample applications to use public [Parameter]s. #12257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Components/Blazor/Build/test/BindRazorIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
int Value { get; set; }
public int Value { get; set; }

[Parameter]
Action<int> ValueChanged { get; set; }
public Action<int> ValueChanged { get; set; }
}
}"));

Expand Down Expand Up @@ -105,10 +105,10 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
int Value { get; set; }
public int Value { get; set; }

[Parameter]
Action<int> OnChanged { get; set; }
public Action<int> OnChanged { get; set; }
}
}"));

Expand Down
16 changes: 8 additions & 8 deletions src/Components/Blazor/Build/test/ChildContentRazorIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
}

[Parameter]
RenderFragment ChildContent { get; set; }
public RenderFragment ChildContent { get; set; }
}
}
");
Expand All @@ -43,10 +43,10 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
}

[Parameter]
RenderFragment<string> ChildContent { get; set; }
public RenderFragment<string> ChildContent { get; set; }

[Parameter]
string Value { get; set; }
public string Value { get; set; }
}
}
");
Expand All @@ -66,19 +66,19 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
}

[Parameter]
string Name { get; set; }
public string Name { get; set; }

[Parameter]
RenderFragment<string> Header { get; set; }
public RenderFragment<string> Header { get; set; }

[Parameter]
RenderFragment<string> ChildContent { get; set; }
public RenderFragment<string> ChildContent { get; set; }

[Parameter]
RenderFragment Footer { get; set; }
public RenderFragment Footer { get; set; }

[Parameter]
string Value { get; set; }
public string Value { get; set; }
}
}
");
Expand Down
32 changes: 16 additions & 16 deletions src/Components/Blazor/Build/test/ComponentRenderingRazorIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ public class SomeType

public class MyComponent : ComponentBase
{
[Parameter] int IntProperty { get; set; }
[Parameter] bool BoolProperty { get; set; }
[Parameter] string StringProperty { get; set; }
[Parameter] SomeType ObjectProperty { get; set; }
[Parameter] public int IntProperty { get; set; }
[Parameter] public bool BoolProperty { get; set; }
[Parameter] public string StringProperty { get; set; }
[Parameter] public SomeType ObjectProperty { get; set; }
}
}
"));
Expand Down Expand Up @@ -135,7 +135,7 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
string StringProperty { get; set; }
public string StringProperty { get; set; }
}
}
"));
Expand Down Expand Up @@ -208,7 +208,7 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
Action<UIMouseEventArgs> OnClick { get; set; }
public Action<UIMouseEventArgs> OnClick { get; set; }
}
}
"));
Expand Down Expand Up @@ -253,7 +253,7 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
Action<UIEventArgs> OnClick { get; set; }
public Action<UIEventArgs> OnClick { get; set; }
}
}
"));
Expand Down Expand Up @@ -298,7 +298,7 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
bool BoolProperty { get; set; }
public bool BoolProperty { get; set; }
}
}"));

Expand Down Expand Up @@ -326,10 +326,10 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
string MyAttr { get; set; }
public string MyAttr { get; set; }

[Parameter]
RenderFragment ChildContent { get; set; }
public RenderFragment ChildContent { get; set; }
}
}
"));
Expand Down Expand Up @@ -370,7 +370,7 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
RenderFragment ChildContent { get; set; }
public RenderFragment ChildContent { get; set; }
}
}
"));
Expand Down Expand Up @@ -416,7 +416,7 @@ namespace Test
{
public class SurveyPrompt : ComponentBase
{
[Parameter] private string Title { get; set; }
[Parameter] public string Title { get; set; }
}
}
"));
Expand Down Expand Up @@ -508,7 +508,7 @@ namespace Test
public class MyComponent : ComponentBase
{
[Parameter]
RenderFragment ChildContent { get; set; }
public RenderFragment ChildContent { get; set; }
}
}
"));
Expand Down Expand Up @@ -571,9 +571,9 @@ namespace Test
{
public class Repeater : ComponentBase
{
[Parameter] int Count { get; set; }
[Parameter] RenderFragment<string> Template { get; set; }
[Parameter] string Value { get; set; }
[Parameter] public int Count { get; set; }
[Parameter] public RenderFragment<string> Template { get; set; }
[Parameter] public string Value { get; set; }

protected override void BuildRenderTree(RenderTreeBuilder builder)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Blazor/Build/test/DirectiveRazorIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public void SupportsInjectDirective()
public class TestLayout : IComponent
{
[Parameter]
RenderFragment Body { get; set; }
public RenderFragment Body { get; set; }

public void Configure(RenderHandle renderHandle)
{
Expand Down
12 changes: 6 additions & 6 deletions src/Components/Blazor/Build/test/GenericComponentRazorIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
}

[Parameter]
List<TItem> Items { get; set; }
public List<TItem> Items { get; set; }

[Parameter]
RenderFragment<Context> ChildContent { get; set; }
public RenderFragment<Context> ChildContent { get; set; }

public class Context
{
Expand All @@ -70,13 +70,13 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
}

[Parameter]
TItem1 Item1 { get; set; }
public TItem1 Item1 { get; set; }

[Parameter]
TItem2 Item2 { get; set; }
public TItem2 Item2 { get; set; }

[Parameter]
TItem3 Item3 { get; set; }
public TItem3 Item3 { get; set; }
}
}
");
Expand Down Expand Up @@ -224,7 +224,7 @@ @typeparam TItem
<GenericContext Items=""@MyItems"" @ref=""_my"" @ref:suppressField />

@code {
[Parameter] List<TItem> MyItems { get; set; }
[Parameter] public List<TItem> MyItems { get; set; }
GenericContext<TItem> _my;
void Foo() { GC.KeepAlive(_my); }
}");
Expand Down
2 changes: 1 addition & 1 deletion ...omponents/Blazor/Templates/src/content/BlazorWasm-CSharp/Client/Shared/SurveyPrompt.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@

@code {
// Demonstrates how a parent component can supply parameters
[Parameter] string Title { get; set; }
[Parameter] public string Title { get; set; }
}
2 changes: 1 addition & 1 deletion src/Components/Blazor/testassets/StandaloneApp/Pages/FetchData.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ else
}

@code {
[Parameter] DateTime StartDate { get; set; }
[Parameter] public DateTime StartDate { get; set; }

WeatherForecast[] forecasts;

Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ public abstract partial class LayoutComponentBase : Microsoft.AspNetCore.Compone
{
protected LayoutComponentBase() { }
[Microsoft.AspNetCore.Components.ParameterAttribute]
protected Microsoft.AspNetCore.Components.RenderFragment Body { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
public Microsoft.AspNetCore.Components.RenderFragment Body { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
}
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
public readonly partial struct MarkupString
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/src/LayoutComponentBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ public abstract class LayoutComponentBase : ComponentBase
/// Gets the content to be rendered inside the layout.
/// </summary>
[Parameter]
protected RenderFragment Body { get; private set; }
public RenderFragment Body { get; private set; }
}
}
2 changes: 1 addition & 1 deletion src/Components/Components/test/Auth/AuthorizeViewTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
// recurse into all descendants because we're passing ChildContent
class NeverReRenderComponent : ComponentBase
{
[Parameter] RenderFragment ChildContent { get; set; }
[Parameter] public RenderFragment ChildContent { get; set; }

protected override bool ShouldRender() => false;

Expand Down
6 changes: 3 additions & 3 deletions src/Components/Components/test/CascadingParameterStateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,19 +389,19 @@ static CascadingValue<T> CreateCascadingValueComponent<T>(T value, string name =
renderer.Dispatcher.InvokeAsync((Action)(() => supplier.SetParametersAsync(ParameterCollection.FromDictionary(supplierParams))));
return supplier;
}

class ComponentWithNoParams : TestComponentBase
{
}

class ComponentWithNoCascadingParams : TestComponentBase
{
[Parameter] bool SomeRegularParameter { get; set; }
[Parameter] public bool SomeRegularParameter { get; set; }
}

class ComponentWithCascadingParams : TestComponentBase
{
[Parameter] bool RegularParam { get; set; }
[Parameter] public bool RegularParam { get; set; }
[CascadingParameter] internal ValueType1 CascadingParam1 { get; set; }
[CascadingParameter] internal ValueType2 CascadingParam2 { get; set; }
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/CascadingParameterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ class CascadingParameterConsumerComponent<T> : AutoRenderComponent
public int NumRenders { get; private set; }

[CascadingParameter] T CascadingParameter { get; set; }
[Parameter] string RegularParameter { get; set; }
[Parameter] public string RegularParameter { get; set; }

public override async Task SetParametersAsync(ParameterCollection parameters)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Components/test/PageDisplayTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ public void CanChangeDisplayedPageWithDifferentLayout()
private class RootLayout : AutoRenderComponent
{
[Parameter]
RenderFragment Body { get; set; }
public RenderFragment Body { get; set; }

protected override void BuildRenderTree(RenderTreeBuilder builder)
{
Expand All @@ -234,7 +234,7 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
private class NestedLayout : AutoRenderComponent
{
[Parameter]
RenderFragment Body { get; set; }
public RenderFragment Body { get; set; }

protected override void BuildRenderTree(RenderTreeBuilder builder)
{
Expand Down
30 changes: 15 additions & 15 deletions src/Components/Components/test/ParameterCollectionAssignmentExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,11 +364,11 @@ class HasInstanceProperties
// "internal" to show we're not requiring public accessors, but also
// to keep the assertions simple in the tests

[Parameter] internal int IntProp { get; set; }
[Parameter] internal string StringProp { get; set; }
[Parameter] public int IntProp { get; set; }
[Parameter] public string StringProp { get; set; }

// Also a truly private one to show there's nothing special about 'internal'
[Parameter] private object ObjectProp { get; set; }
[Parameter] public object ObjectProp { get; set; }

public static string ObjectPropName => nameof(ObjectProp);
public object ObjectPropCurrentValue
Expand All @@ -386,7 +386,7 @@ class HasPropertyWithoutParameterAttribute
class HasPropertyWhoseSetterThrows
{
[Parameter]
internal string StringProp
public string StringProp
{
get => string.Empty;
set => throw new InvalidOperationException("This setter throws");
Expand All @@ -395,37 +395,37 @@ internal string StringProp

class HasInheritedProperties : HasInstanceProperties
{
[Parameter] internal int DerivedClassIntProp { get; set; }
[Parameter] public int DerivedClassIntProp { get; set; }
}

class HasParametersVaryingOnlyByCase
{
[Parameter] internal object MyValue { get; set; }
[Parameter] internal object Myvalue { get; set; }
[Parameter] public object MyValue { get; set; }
[Parameter] public object Myvalue { get; set; }
}

class HasParameterClashingWithInherited : HasInstanceProperties
{
[Parameter] new int IntProp { get; set; }
[Parameter] public new int IntProp { get; set; }
}

class HasCaptureUnmatchedValuesProperty
{
[Parameter] internal int IntProp { get; set; }
[Parameter] internal string StringProp { get; set; }
[Parameter] internal object ObjectProp { get; set; }
[Parameter(CaptureUnmatchedValues = true)] internal IReadOnlyDictionary<string, object> CaptureUnmatchedValues { get; set; }
[Parameter] public int IntProp { get; set; }
[Parameter] public string StringProp { get; set; }
[Parameter] public object ObjectProp { get; set; }
[Parameter(CaptureUnmatchedValues = true)] public IReadOnlyDictionary<string, object> CaptureUnmatchedValues { get; set; }
}

class HasDupliateCaptureUnmatchedValuesProperty
{
[Parameter(CaptureUnmatchedValues = true)] internal Dictionary<string, object> CaptureUnmatchedValuesProp1 { get; set; }
[Parameter(CaptureUnmatchedValues = true)] internal IDictionary<string, object> CaptureUnmatchedValuesProp2 { get; set; }
[Parameter(CaptureUnmatchedValues = true)] public Dictionary<string, object> CaptureUnmatchedValuesProp1 { get; set; }
[Parameter(CaptureUnmatchedValues = true)] public IDictionary<string, object> CaptureUnmatchedValuesProp2 { get; set; }
}

class HasWrongTypeCaptureUnmatchedValuesProperty
{
[Parameter(CaptureUnmatchedValues = true)] internal KeyValuePair<string, object>[] CaptureUnmatchedValuesProp { get; set; }
[Parameter(CaptureUnmatchedValues = true)] public KeyValuePair<string, object>[] CaptureUnmatchedValuesProp { get; set; }
}

class ParameterCollectionBuilder : IEnumerable
Expand Down
Loading