Remove stateful prerendering #12714
Merged
Remove stateful prerendering #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
requested review from
ryanbrandenburg,
SteveSandersonMS and
a team
as code owners
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
src/Components/Server/ref/Microsoft.AspNetCore.Components.Server.netcoreapp3.0.cs
Show resolved
Hide resolved
rynowak
force-pushed
the
rynowak/remove-stateful-prerendering
branch
from
aabe723
to
a3a482b
Compare
rynowak
commented
Jul 30, 2019
src/Components/Server/ref/Microsoft.AspNetCore.Components.Server.netcoreapp3.0.cs
Show resolved
Hide resolved
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
rynowak
commented
Jul 30, 2019
src/Mvc/test/WebSites/BasicWebSite/Controllers/RazorComponentsController.cs
Show resolved
Hide resolved
rynowak
force-pushed
the
rynowak/remove-stateful-prerendering
branch
from
a3a482b
to
7b702df
Compare
pranavkm
reviewed
Jul 30, 2019
src/Components/test/testassets/ComponentsApp.Server/ComponentsApp.Server.csproj
Show resolved
Hide resolved
mkArtakMSFT
added
tell-mode
rynowak
force-pushed
the
rynowak/remove-stateful-prerendering
branch
3 times, most recently
from
0463028
to
41cfa1a
Compare
|
@SteveSandersonMS @javiercn - please take a look |
rynowak
force-pushed
the
rynowak/remove-stateful-prerendering
branch
2 times, most recently
from
32f1338
to
5ad2679
Compare
javiercn
reviewed
Jul 31, 2019
SteveSandersonMS
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Approving because this looks great and I don't want to holding anything up, but please check #12714 (comment). My comment there might be wrong but if it's not it's definitely worth fixing.
rynowak
force-pushed
the
rynowak/remove-stateful-prerendering
branch
2 times, most recently
from
e8f5e02
to
c1476cd
Compare
Fixes: #12245 Fixes: #12630 This change removes stateful pre-rendering from Server-Side Blazor. This means that when you render a component during the initial HTTP request, we we will no longer preserve the component instances and their parameters. While this feature was useful, it cause serious scalability concerns. This means that it will now be required to register "entry-point" components in startup similar to client-side Blazor.
rynowak
force-pushed
the
rynowak/remove-stateful-prerendering
branch
from
c1476cd
to
2c64eae
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12245
Fixes: #12630
This change removes stateful pre-rendering from Server-Side Blazor. This
means that when you render a component during the initial HTTP request,
we we will no longer preserve the component instances and their
parameters. While this feature was useful, it cause serious scalability
concerns.
This means that it will now be required to register "entry-point"
components in startup similar to client-side Blazor.