Treat FormatExceptions and OverflowExceptions to be treated as model state errors #15035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…state errors In SystemTextJsonInputFormatter and NewtonsoftJsonInputFormatter, suppress FormatExceptions and OverflowExceptions and instead report them as model state errors. This makes the behavior more consistent between these formatters, model binders, and the XML formatters Fixes #14504
ryanbrandenburg
approved these changes
Oct 15, 2019
pranavkm
commented
Oct 15, 2019
| @@ -196,8 +196,15 @@ public virtual InputFormatterExceptionPolicy ExceptionPolicy | |||
| } | |||
| } | |||
|
|
|||
| if (!(exception is JsonException || exception is OverflowException)) | |||
| if (!(exception is JsonException || exception is OverflowException || exception is FormatException)) | |||
There was a problem hiding this comment.
I dug around and OverflowException made the list because there was a test that broke if it wasn't allowed. Since it looks like an oversight, I don't think there's a compelling reason to put this behind a compat flag. The SystemTextJson one was a similar oversight.
Thoughts?
javiercn
added
the
area-mvc
JamesNK
approved these changes
Oct 16, 2019
|
I spoke to @dougbu offline about this and he agreed this looked like the right change. Merging this in |
dougbu
reviewed
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SystemTextJsonInputFormatter and NewtonsoftJsonInputFormatter, suppress
FormatExceptions and OverflowExceptions and instead report them as model state errors.
This makes the behavior more consistent between these formatters, model binders, and
the XML formatters
Fixes #14504