Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate random port for the server project #18842

Merged
merged 3 commits into from
Feb 9, 2020

Conversation

mkArtakMSFT
Copy link
Member

Fix the generated launchSettings.json so that the ports are random and the project name is wrong.

Addresses #18612

@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label Feb 6, 2020
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Feb 6, 2020
@mkArtakMSFT mkArtakMSFT removed the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 6, 2020
@danroth27
Copy link
Member

@mkArtakMSFT Should this also address fixing the name of the project launch profile? Currently the project launch profile is always generated as Company1.WebApplication1. I'm guessing this token doesn't get replaced because the sourceName in the template.json file is "BlazorWasm-CSharp" instead of "Company1.WebApplication1".

@mkArtakMSFT
Copy link
Member Author

@mkArtakMSFT Should this also address fixing the name of the project launch profile? Currently the project launch profile is always generated as Company1.WebApplication1. I'm guessing this token doesn't get replaced because the sourceName in the template.json file is "BlazorWasm-CSharp" instead of "Company1.WebApplication1".

That's exactly why this is still in Draft.

@mkArtakMSFT mkArtakMSFT marked this pull request as ready for review February 8, 2020 00:03
@mkArtakMSFT mkArtakMSFT merged commit d39ed09 into blazor-wasm Feb 9, 2020
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT/launchSettings branch February 9, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The launchSettings.json in an ASP.NET Core hosted Blazor WebAssembly app isn't generated correctly
3 participants