Skip to content

[Blazor] Auth fixes #20191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2020
Merged

[Blazor] Auth fixes #20191

merged 4 commits into from
Mar 26, 2020

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Mar 26, 2020 •
edited
Loading

Fixes #19877
Fixes #19958
Fixes #19855
Fixes #19854
Fixes #19998

javiercn added 3 commits March 26, 2020 07:17
@javiercn
Cleanup startup apis
90a032a 
Fix redirect to login

Escape data string

Fix async initialization bug

Add metadata url

Update msal cache option

Fix base path issue
@javiercn
Fix issue in silent token acquisition
e2f9ede
@javiercn
Normalize action before use in RemoteAuthenticatorViewCore
4682070
@javiercn
Copy link
Member Author

From @SteveSandersonMS in the other PR

Is there any chance we're a bit short on test coverage with some of this? It's unusual to be able to fix a wide range of issues without impacting or adding any tests.

I'm particularly thinking about the DI parts here - there are a lot of different combinations of overloads. Do you think they would be amenable to unit testing, or can this only be seen at the E2E level?

This PR doesn't include the tests, but I've already build a separate PR on top of this one with additional tests.

@javiercn javiercn changed the title Javiercn/blazor wasm auth fixes [Blazor] Auth fixes Mar 26, 2020
@javiercn javiercn merged commit b0a95d0 into blazor-wasm Mar 26, 2020
@javiercn javiercn mentioned this pull request Mar 26, 2020
Closed
@BrennanConroy BrennanConroy deleted the javiercn/blazor-wasm-auth-fixes branch January 7, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiercn @SteveSandersonMS