Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blazor][Wasm] Build fixes #20861

Merged
merged 4 commits into from
Apr 15, 2020
Merged

[Blazor][Wasm] Build fixes #20861

merged 4 commits into from
Apr 15, 2020

Conversation

javiercn
Copy link
Member

  • Fixes broken incrementalism
  • Add functional tests to validate incrementalism works

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Apr 15, 2020
This was linked to issues Apr 15, 2020
Publish hosted PWA from VS is broken #20789
Closed
Regression in build incrementalism for Blazor #20858
Closed
SteveSandersonMS
SteveSandersonMS approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@captainsafia captainsafia marked this pull request as ready for review April 15, 2020 16:33
@javiercn javiercn merged commit ad72586 into blazor-wasm Apr 15, 2020
@javiercn javiercn deleted the javiercn/build-fixes branch April 15, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in build incrementalism for Blazor Publish hosted PWA from VS is broken
4 participants
@javiercn @pranavkm @SteveSandersonMS @captainsafia