A quick collection of quick fixes #20993
Conversation
|
Additional verification builds
|
dougbu
force-pushed
the
dougbu/quick.fixes
branch
2 times, most recently
from
3c4a685 to
8ee921f
Compare
Pilchie
added
the
area-infrastructure
dougbu
force-pushed
the
dougbu/quick.fixes
branch
3 times, most recently
from
eaea3ec to
b0f4606
Compare
dougbu
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
|
Oops, missing a commit and I forgot to rerun some validation builds. Back to draft… |
dougbu
force-pushed
the
dougbu/quick.fixes
branch
from
b0f4606 to
1102190
Compare
| @@ -31,12 +31,12 @@ stages: | |||
| steps: | |||
| - script: git submodule init | |||
| - script: git submodule update --recursive | |||
| - script: cd ./src/Components | |||
There was a problem hiding this comment.
@mkArtakMSFT you may want to look at this file in particular
There was a problem hiding this comment.
Looks fine to me. I initially have totally forgotten that this is something I had created. Thanks @pranavkm for reminding this 👍
Anyway, the change looks reasonable. We should discuss in our next meeting whether this is still useful. We tend to look at the official CI views rather than this any more, so maybe it's time to completely stop this.
| @@ -1,4 +1,6 @@ | |||
| <Project> | |||
| <Import Project="eng\Common.props" /> | |||
There was a problem hiding this comment.
Without this, $(BuildNative) was only available in the projects that needed it when property was global
| @@ -1,26 +1,40 @@ | |||
| @ECHO OFF | |||
| SET RepoRoot=%~dp0..\.. | |||
|
|
|||
| ECHO Building Microsoft.AspNetCore.Runtime.SiteExtension | |||
There was a problem hiding this comment.
@JunTaoLuo this one's for you 😈
|
Marking this as ready to review though validation builds (all but devBuilds.yml one) are failing due to what appear to be general infrastructure issues |
- remove an excess build step
- quote all rooted paths - check `%ERRORLEVEL%` after every `CALL` - nits: - add a few more `ECHO` commands - wrap long lines
…ers.beforeBuild` - ensure NuGet.config is ready for all internal builds - remove now-duplicate `SetupNugetSources` invocations wherever default-build.yml is used
- fix problems using `-all` or `/p:BuildAllProjects=true` without `-buildNative` - ensure `$(BuildNative)` is `false` where it's not supported - move some duplicated settings into eng/Common.props and `<Import />` the new file - remove now-duplicated parts of conditions using `$(BuildNative)`
- remove need to specify `/p:BuildAllProjects=true` - nit: simplify some Boolean logic
- avoid `/p:Build*` on the command line (except with eng/scripts/ci-source-build.sh) - nits: - remove now-useless `-buildNative` with `-all` - expand and correct a couple of related comments and messages
dougbu
force-pushed
the
dougbu/quick.fixes
branch
from
1102190 to
bc8ab4e
Compare
|
🆙📅 to pick up latest from 'master'. @mkArtakMSFT and @JunTaoLuo please weigh in. |
SetupNugetSourcesscript invocations aboveparameters.beforeBuild$(BuildNative)is always set correctly-alltogether with-projects--build-*(Mostly found while working on #20748. Some parts will make it easier to use
dotnetmore if we continue down that road.)