Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MonoProxy bits to mono@f8d27a4847d9e28f707d6fd9bdf117fcdcc5f33d #24134

Closed
wants to merge 2 commits into from

Conversation

radical
Copy link
Member

@radical radical commented Jul 20, 2020

The last update of the proxy was in May:

commit 22522a0d78077cefbf86728534a564f2dc6edbd4
Author: Pranav K <prkrishn@hotmail.com>
Date:   Mon May 11 10:40:12 2020 -0700

    Update to mono sources http://github.com/mono/mono/commit/57dcba253 (#21700)

This brings it up to mono/master.

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jul 20, 2020
@radical radical marked this pull request as ready for review July 20, 2020 23:51
@radical radical requested review from SteveSandersonMS and a team as code owners July 20, 2020 23:51
@radical radical requested a review from lewing July 20, 2020 23:53
@pranavkm
Copy link
Contributor

@captainsafia, all yours

@captainsafia
Copy link
Member

Thanks for submitting this, @radical!

Changing the target branch for this to the preview8 release branch. Might as well get these changes out early to catch any regressions in validation.

@captainsafia captainsafia changed the base branch from master to release/5.0-preview8 July 21, 2020 02:26
@captainsafia captainsafia requested a review from a team July 21, 2020 02:26
@captainsafia captainsafia changed the base branch from release/5.0-preview8 to master July 21, 2020 02:26
@radical
Copy link
Member Author

radical commented Jul 21, 2020

This is the corresponding runtime PR - dotnet/runtime#39663 .

@lewing
Copy link
Member

lewing commented Jul 21, 2020

@radical @captainsafia make sure the branches are in sync, targeting p8 for this only makes sense if dotnet/runtime p8 matches

@Tratcher Tratcher removed the request for review from a team July 21, 2020 03:43
@radical
Copy link
Member Author

radical commented Jul 21, 2020

I missed some changes, I'm going to try it out, and then push again.

@radical
Copy link
Member Author

radical commented Jul 21, 2020

This update enables property getters on objects, among other things:

Screen Shot 2020-07-21 at 1 05 00 PM

@captainsafia
Copy link
Member

@radical @lewing I assume these bits will be included in the MonoProxy package? If so, we might want to abandon this PR in favor of consuming the package directly in preview8.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't want to merge this but it is helpful to keep it open for tracking purposes

@captainsafia
Copy link
Member

Yes, I don't want to merge this but it is helpful to keep it open for tracking purposes

ACK. Sounds good!

@radical radical closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants