Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Move to GenericHost #24282

Merged
merged 3 commits into from
Jul 27, 2020
Merged

[Security] Move to GenericHost #24282

merged 3 commits into from
Jul 27, 2020

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Jul 24, 2020

Part of #20964

@Kahbazi Kahbazi requested a review from Tratcher as a code owner July 24, 2020 15:16
@ghost ghost added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jul 24, 2020
@Tratcher Tratcher requested a review from BrennanConroy July 24, 2020 16:24
@Tratcher
Copy link
Member

Test failures, the host needs to be started.
https://dev.azure.com/dnceng/public/_build/results?buildId=744604&view=ms.vss-test-web.build-test-results-tab&runId=23077256&resultId=105506&paneView=debug

@BrennanConroy BrennanConroy merged commit 6097145 into dotnet:master Jul 27, 2020
@BrennanConroy
Copy link
Member

Thanks!

@BrennanConroy BrennanConroy added this to the 5.0.0-rc1 milestone Jul 27, 2020
@BrennanConroy BrennanConroy mentioned this pull request Jul 27, 2020
Open
@Kahbazi Kahbazi deleted the kahbazi/SecurityHostBuilder branch July 27, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@Kahbazi @Tratcher @BrennanConroy