[Hosting] Move to GenericHost #24297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
I think we've already converted the Hosting tests that can be converted, many tests cover both WebHostBuilder and HostBuilder. Let me know if you see any that use |
| .UseConfiguration(config) | ||
| .UseKestrel() | ||
| .UseStartup<StartupBlockingOnStart>() | ||
| var host = new HostBuilder() |
There was a problem hiding this comment.
I think this sample will hang if Stop/StopAsync isn't called?
BrennanConroy
approved these changes
Jul 27, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20964
Should I also change the unit tests which uses
WebHostBuilder, or thoses unit tests are directly forWebHostBuilder?