Skip to content

Enable string comparison FxCop rules #24567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enable string comparison FxCop rules #24567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,8 @@ end_of_line = lf

[*.{razor,cshtml}]
charset = utf-8-bom

[*.cs]
dotnet_diagnostic.CA1307.severity = error
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want CA1310 here instead of CA1307 from the latest package.
CA1307 will continue to have its old behavior of being a readability/maintainability rule which provides the recommendation regardless of the default string comparison used by the flagged methid. It has been disabled by default as it can be noisy if you only care about correctness. CA1310 is the new rule which only flags string methods which are known to default to culture specific string comparisons, and is the correctness rule which will not be noisy.

dotnet_diagnostic.CA1308.severity = error
dotnet_diagnostic.CA1309.severity = error
4 changes: 4 additions & 0 deletions eng/tools/RepoTasks/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[*.cs]
dotnet_diagnostic.CA1307.severity = none
dotnet_diagnostic.CA1308.severity = none
dotnet_diagnostic.CA1309.severity = none
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually fix the 3 violations in this directory and remove this, but I figured I'd at least push something that runs the "restore" step.