Skip to content

Add public API baselines for SiteExtensions, Testing, WebEncoders #25654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

Pilchie
Copy link
Member

@Pilchie Pilchie commented Sep 6, 2020

No description provided.

@Pilchie Pilchie added this to the 5.0.0-rc2 milestone Sep 6, 2020
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 6, 2020
@Pilchie
Copy link
Member Author

Pilchie commented Sep 6, 2020

Part of #24347

@@ -5,6 +5,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fairly big change given this isn't a shipping package. I'm not even sure why it's packable. Might want to revert all changes under src/Testing. Up to you.

I should have realized this when I wrote up #24347.

@dougbu
Copy link
Member

dougbu commented Sep 6, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Pilchie
Copy link
Member Author

Pilchie commented Sep 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Pilchie Pilchie added auto-merge tell-mode Indicates a PR which is being merged during tell-mode labels Sep 10, 2020
@ghost
Copy link

ghost commented Sep 10, 2020

Hello @Pilchie!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Pilchie Pilchie merged commit 848f42d into dotnet:release/5.0-rc2 Sep 10, 2020
@Pilchie Pilchie deleted the api-baselines-rest branch September 10, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants