Fix some issues causing aspnetcore-helix-matrix failures #26840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I manually triggered the aspnetcore-helix-matrix pipeline on the halter73/fix-helix-matrix PR branch and now it's showing up under the PR checks. I wonder if GitHub will block merging now if it fails 🤔 |
TanayParikh
approved these changes
Oct 13, 2020
Tratcher
approved these changes
Oct 13, 2020
| @@ -43,7 +43,7 @@ | |||
| <ItemGroup Condition="'$(TargetArchitecture)' == 'arm64' AND '$(IsHelixDaily)' == 'true' AND '$(IsWindowsOnlyTest)' != 'true'"> | |||
| <HelixAvailableTargetQueue Include="(Debian.9.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036" Platform="Linux" /> | |||
| </ItemGroup> | |||
| <ItemGroup Condition="'$(TargetArchitecture)' == 'arm64' AND '$(IsHelixDaily)' == 'true'"> | |||
| <ItemGroup Condition="'$(IsWindowsOnlyTest)' != 'true' AND '$(TargetArchitecture)' == 'arm64' AND '$(IsHelixDaily)' == 'true'"> | |||
There was a problem hiding this comment.
Is there an issue tracking this part? The initial error looked like an easy fix in TestMatrix.
There was a problem hiding this comment.
I don't believe so, @halter73 could you please confirm? If not, I'll create a new one.
There was a problem hiding this comment.
Thanks @TanayParikh, but I got it. #26872
Pilchie
added
the
area-infrastructure
> [0.019s] [Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware] [Information] HTTP/2 over TLS is not supported on Windows versions older than Windows 10 and Windows Server 2016 due to incompatible ciphers or missing ALPN support. Falling back to HTTP/1.1 instead.
…ficate on Windows.10.Arm64.Open
halter73
force-pushed
the
halter73/fix-helix-matrix
branch
from
3242ec7 to
30cc292
Compare
|
The recent aspnetcore-helix-matrix failures are related to https://github.com/dotnet/core-eng/issues/10962. I'm merging this since all the PR checks passed. |
|
Thanks @halter73! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example failures:
https://dev.azure.com/dnceng/public/_build/results?buildId=848189&view=ms.vss-test-web.build-test-results-tab