Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MapAction overload #30563

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Remove MapAction overload #30563

merged 2 commits into from
Mar 2, 2021

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Mar 2, 2021

  • Remove IRotePatternMetadata
  • Remove IRouteOrderMetadata

Follow up to #30556

@halter73
Remove MapAction overload
4516e46 
- Remove IRotePatternMetadata
- Remove IRouteOrderMetadata
@davidfowl
Copy link
Member

This makes migration to MVC only a little more difficult but removes confusion over what this metadata even means so I like it.

@halter73
Copy link
Member Author

halter73 commented Mar 2, 2021

Since Routing doesn't have a dependency on the MVC routing attributes (e.g. [MapGet("/route")]) and those attributes no longer implement Routing interfaces, there's no longer an easy way to throw when given these unsupported attributes. I'm thinking this might be a good thing to write an analyzer for.

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 2, 2021
@halter73 halter73 merged commit 78973a2 into main Mar 2, 2021
@halter73 halter73 deleted the halter73/mapaction-cleanup branch March 2, 2021 19:26
@halter73 halter73 added the feature-minimal-actions Controller-like actions for endpoint routing label Mar 2, 2021
@halter73 halter73 mentioned this pull request Mar 2, 2021
Merged
@halter73 halter73 mentioned this pull request Apr 20, 2021
Closed
@amcasey amcasey added the area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

@JamesNK JamesNK Awaiting requested review from JamesNK

@javiercn javiercn Awaiting requested review from javiercn javiercn is a code owner

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-minimal-actions Controller-like actions for endpoint routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@halter73 @davidfowl @Pilchie @amcasey