Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LoggerMessage.Define in HttpSys #31333

Merged
merged 4 commits into from
Mar 28, 2021
Merged

Use LoggerMessage.Define in HttpSys #31333

merged 4 commits into from
Mar 28, 2021

Commits on Mar 28, 2021

  1. Use LoggerMessage.Define in HttpSys 

    Use LoggerMessage.Define() throughout HttpSys instead of ILogger extension methods.
Also updates two incorrect event Id field names.
Addresses dotnet#31313.
    @martincostello
    martincostello committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    b239111 View commit details
    Browse the repository at this point in the history

  2. Remove log partials with one message 

    Move the log partial classes that only contained one logger message directly into the classes that use them.
    @martincostello
    martincostello committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    36de4d7 View commit details
    Browse the repository at this point in the history

  3. Split events that shared an event ID 

    Add new CreateDisconnectTokenError event ID to use for the less verbose variant of the log message that was also using DisconnectRegistrationError.
    @martincostello
    martincostello committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    cded083 View commit details
    Browse the repository at this point in the history

  4. Restore nested Log classes 

    Restore 36de4d7 but as nested classes in the same file, rather than a partial.
    @martincostello
    martincostello committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    b13dd4d View commit details
    Browse the repository at this point in the history