Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set locale for ubuntu 18.04 #31649

Merged
1 commit merged into from
Apr 9, 2021
Merged

Set locale for ubuntu 18.04 #31649

1 commit merged into from
Apr 9, 2021

Conversation

JunTaoLuo
Copy link
Contributor

Updating CI to set locale for ubuntu18.04.

@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework auto-merge labels Apr 9, 2021
@JunTaoLuo JunTaoLuo requested review from dougbu and wtgodbe April 9, 2021 19:48
@ghost
Copy link

ghost commented Apr 9, 2021

Hello @JunTaoLuo!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@@ -116,6 +116,10 @@ jobs:
- DOTNET_CLI_HOME: $(System.DefaultWorkingDirectory)
- DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
- TeamName: AspNetCore
- ${{ if eq(parameters.agentOs, 'Linux') }}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Up to you but I wouldn't bother w/ making this platform-specific. The variables can help on macOS and don't hurt on Windows.

@ghost ghost merged commit 13a34c6 into release/3.1 Apr 9, 2021
@ghost ghost deleted the johluo/ubuntu-locale branch April 9, 2021 21:54
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 10, 2021
@dougbu dougbu added this to the 3.1.15 milestone Jun 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants