Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SignalR] Allocate HubCallerClients once per connection #31661

Merged
merged 1 commit into from
Apr 10, 2021
Merged

[SignalR] Allocate HubCallerClients once per connection #31661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/SignalR/server/Core/src/HubConnectionContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ internal StreamTracker StreamTracker
}

internal HubCallerContext HubCallerContext { get; }
internal HubCallerClients HubCallerClients { get; set; } = null!;

internal Exception? CloseException { get; private set; }

Expand Down
3 changes: 2 additions & 1 deletion src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public DefaultHubDispatcher(IServiceScopeFactory serviceScopeFactory, IHubContex
public override async Task OnConnectedAsync(HubConnectionContext connection)
{
var scope = _serviceScopeFactory.CreateScope();
connection.HubCallerClients = new HubCallerClients(_hubContext.Clients, connection.ConnectionId);

try
{
Expand Down Expand Up @@ -558,7 +559,7 @@ private async Task SendInvocationError(string? invocationId,

private void InitializeHub(THub hub, HubConnectionContext connection)
{
hub.Clients = new HubCallerClients(_hubContext.Clients, connection.ConnectionId);
hub.Clients = connection.HubCallerClients;
hub.Context = connection.HubCallerContext;
hub.Groups = _hubContext.Groups;
}
Expand Down