Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Unshipped.txt in previews #31982

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Conversation

BrennanConroy
Copy link
Member

No description provided.

@BrennanConroy BrennanConroy added the tell-mode Indicates a PR which is being merged during tell-mode label Apr 20, 2021
@BrennanConroy BrennanConroy added this to the 6.0-preview4 milestone Apr 20, 2021
@BrennanConroy BrennanConroy requested a review from a team as a code owner April 20, 2021 18:20
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 20, 2021
@dougbu
Copy link
Member

dougbu commented Apr 20, 2021

And, yes, I agree this is tell-mode. But, @BrennanConroy is something blocked that's already approved for preview4❔ @Pilchie and @wtgodbe are we in a time crunch here❔

@Pilchie
Copy link
Member

Pilchie commented Apr 20, 2021

We'd like to get Preview 4 changes in hopefully by EOD today, and I expect at least these 3 are blocked.

  1. Add new Use middleware extension method #31784
  2. Adds HttpLogging middleware #31816
  3. Minimal hosting #31825

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Apr 20, 2021

Two are blocked because the check is only for "modified from main", one of those has completely new files so wont be affected.

@BrennanConroy BrennanConroy mentioned this pull request Apr 20, 2021
10 tasks
@halter73
Copy link
Member

Do we plan on doing this for every release we have ASK mode changes?

@BrennanConroy
Copy link
Member Author

Do we plan on doing this for every release we have ASK mode changes?

What do you mean? This is a permanent change to the script, so only needs to be done once.

@halter73
Copy link
Member

I didn't look carefully enough. I assumed you just removed the .Unshipped.txt check altogether and approved because I want my PR merged 😆

If all the other checks passed, do we have to rerun checks after this is merged in the other PRs? Or can we just force it?

@JunTaoLuo JunTaoLuo merged commit bf9bd30 into release/6.0-preview4 Apr 20, 2021
@JunTaoLuo JunTaoLuo deleted the brecon/unshipped branch April 20, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants