Make Razor.slnf buildable from command-line #32141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
KirillOsenkov
changed the title
With the comma building Razor.slnf from command-line results in error: Solution file error MSB5025: Json in solution filter file "C:\AspNetCore\src\Razor\razor.slnf" is incorrectly formatted.
KirillOsenkov
force-pushed
the
dev/kirillo/slnf
branch
from
06e4c9d to
1d01c6e
Compare
|
Ugh, seems like we should try to make MSBuild and VS have the same level of resiliency - @rainersigwald |
Pilchie
approved these changes
Apr 25, 2021
|
I filed dotnet/msbuild#6371 |
|
Hi @KirillOsenkov. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Great news! dotnet/msbuild#6346 fixed this for 16.10/5.0.300. |
|
Hi @rainersigwald. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Awesome, thanks @rainersigwald ! |
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
With the comma building Razor.slnf from command-line results in error: Solution file error MSB5025: Json in solution filter file "C:\AspNetCore\src\Razor\razor.slnf" is incorrectly formatted. Commit migrated from dotnet/aspnetcore@af981028f480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the comma building Razor.slnf from command-line results in error:
Solution file error MSB5025: Json in solution filter file "C:\AspNetCore\src\Razor\razor.slnf" is incorrectly formatted.