-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to angular 11 #32182
Upgrade to angular 11 #32182
Conversation
@javiercn I hand ported the initial changes back to the templates |
@HaoK this looks great, does it cover the auth options? |
No I will do that now, and do another port, were there any differences between individual/b2c that I need to look out for? Is one a superset? |
Oh never mind, looks like there's only individual auth option for spa |
.../content/Angular-CSharp/ClientApp/src/api-authorization/login-menu/login-menu.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good to me so far,
I think we'll have to check the generated templates to understand if there's anything that needs to be updated.
It would be great if you can generate a couple of versions of the templates (no auth and auth) and push them to a repo so that we can play with them a bit.
https://github.com/HaoK/Random/tree/haok/temp/angular6 and https://github.com/HaoK/Random/tree/haok/temp/angular6ind |
Let me give this a try tomorrow. I can just remove the proxy and start things manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fixes #14076
Open issues to follow up on:
Angular:
ng run test - fails due to office tabs popping up
npm run build:ssr - fails with "Schema validation failed with the following errors:
Data path "" should NOT have additional properties(vendorChunk)."