Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotnet certificate #32584

Merged
merged 1 commit into from
May 12, 2021
Merged

Use dotnet certificate #32584

merged 1 commit into from
May 12, 2021

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented May 11, 2021

Use the dotnet certificate instead of Microsoft400.

dotnet/announcements#184

@mmitche mmitche requested a review from a team as a code owner May 11, 2021 18:44
@mmitche mmitche requested a review from dougbu May 11, 2021 18:45
@mmitche
Copy link
Member Author

mmitche commented May 11, 2021

@mmitche
Copy link
Member Author

mmitche commented May 11, 2021

This may depend on #32585, but official build will show if or if not.

@mmitche
Copy link
Member Author

mmitche commented May 11, 2021

Merged manifest looks good.

@mmitche
Copy link
Member Author

mmitche commented May 11, 2021

@dougbu What to do about the compile errors in the quarantined tests?

@dougbu
Copy link
Member

dougbu commented May 11, 2021

What to do about the compile errors in the quarantined tests?

I thought we fixed the Razor compilation errors everywhere @captainsafia❔ Either way, it's nothing related to your change @mmitche


Separately, GitHub makes it look like you're updating the MessagePack-CSharp submodule and restoring the NuGet.config file there. Please do not do that.

@mmitche
Copy link
Member Author

mmitche commented May 11, 2021

Separately, GitHub makes it look like you're updating the MessagePack-CSharp submodule and restoring the NuGet.config file there. Please do not do that.

Agh...one sec let me fix that...I use git commit -a a lot.

@dougbu
Copy link
Member

dougbu commented May 11, 2021

I use git commit -a a lot.

No, never do that because it's an extra character to type😀 git commit . all day, every day.

But, you might want to use git submodule update --init --force --recursive a lot too😉

@mmitche
Copy link
Member Author

mmitche commented May 11, 2021

I use git commit -a a lot.

No, never do that because it's an extra character to type😀 git commit . all day, every day.

But, you might want to use git submodule update --init --force --recursive a lot too😉

Option B: never use submodules :D

@captainsafia
Copy link
Member

I thought we fixed the Razor compilation errors everywhere @captainsafia❔ Either way, it's nothing related to your change @mmitche

Not yet. We've been trying different things. The latest hammer attempt is #32581

@mmitche mmitche merged commit 2078ab4 into dotnet:main May 12, 2021
@ghost ghost added this to the 6.0-preview5 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants