Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IResult Implementation For ContentResult #32679

Merged
merged 3 commits into from
May 14, 2021
Merged

IResult Implementation For ContentResult #32679

merged 3 commits into from
May 14, 2021

Conversation

ilkayilknur
Copy link
Contributor

Contributes #32565

@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels May 14, 2021
@ilkayilknur
Copy link
Contributor Author

I see that you've been assigned for the other implementation PRs. You might want to review this PR as well. @halter73

@ilkayilknur ilkayilknur requested a review from halter73 May 14, 2021 19:50
@uabarahona uabarahona mentioned this pull request May 14, 2021
Merged
6 tasks
halter73
halter73 approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@halter73 halter73 merged commit 1448cd9 into dotnet:main May 14, 2021
@ghost ghost added this to the 6.0-preview5 milestone May 14, 2021
davidfowl
davidfowl reviewed May 15, 2021
View reviewed changes
src/Mvc/Mvc.Core/src/ContentResult.cs
{
response.ContentLength = resolvedContentTypeEncoding.GetByteCount(Content);

await using (var textWriter = new HttpResponseStreamWriter(response.Body, resolvedContentTypeEncoding))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks inefficient. Can we just use Response.WriteAsync?

@ilkayilknur ilkayilknur mentioned this pull request May 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@halter73 halter73 halter73 approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@pranavkm pranavkm Awaiting requested review from pranavkm

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
6.0-preview5
Development

Successfully merging this pull request may close these issues.
3 participants
@ilkayilknur @halter73 @davidfowl