Update cert that became valid and broke tests #32812
Conversation
ghost
added
the
|
fyi @dotnet/aspnet-build all helix test runs will fail until this is fixed |
|
In all branches...so let me know where this change needs to be merged |
|
Fun stuff, we had two copies of these certs, the ones in shared/tests are the correct ones to update :) |
|
Test still failing only on ubuntu for some reason, skipping for now to unblock builds, will reenable in a future PR |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@HaoK I'm going to merge this change once all the builds (except Helix) pass. There's a deadlock between getting this change in + getting the E2E changes which are both required to unblock the build. FYI @dotnet/aspnet-build |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/862115327 |
|
Hi @github-actions[bot]. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
/backport to release/3.1 |
|
Started backporting to release/3.1: https://github.com/dotnet/aspnetcore/actions/runs/862116167 |
|
Hi @github-actions[bot]. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Unless I'm off-base, these backports won't work yet. Should be a quick fix (ported from dotnet/runtime) but I haven't seen @wtgodbe's PR to do it yet. |
|
Edit Nevermind, it's github-actions[bot] that's triggering msftbot. |
|
So don't use the bot just manually port these? |
For now, focus on preview5 please. Otherwise, we've got some time. |
|
This is already in preview5 I believe, I see it here: 2e20bab |
👍 Bottom line: I'd wait for @wtgodbe's fix before worrying about backports. |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/878059864 |
|
/backport to release/3.1 |
|
Started backporting to release/3.1: https://github.com/dotnet/aspnetcore/actions/runs/878061375 |
|
@HaoK I know this is old, but how did you decide on 10 years out instead of the original 50 years out (or longer)? |
* [release/5.9] Update branding to v5.0.8 - disable baseline validation * [release/5.0] Update cert that became valid and broke tests - backport of 2e20bab (#32812) - dupe of #33033 * Update cert to not be valid for 50 years * Make cert valid in 10 years * Delete unused copy of certs, update right one * Skip test for now * [release/5.0] Update Chrome driver - backport of e7b5aa6 (#33019) * [release/5.0] Update selenium chrome driver - backport of af96aba (#33043)
|
I asked @blowdart for an appropriate expiration since he wrote these tests originally that's the number he suggested, I just randomly picked 50 to start since that seems safe enough that we would never have to worry about this cert test failing again :) |
We had a cert that wasn't supposed to valid until 5/17/2021, which passed, updated the cert to be valid in 10 years instead. Will file another issue to generate these certs dynamically rather than relying on checked certs